compare URI-decoded path params #482
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zvkemp
commented
Oct 22, 2024
| @@ -74,12 +74,12 @@ def allow_request?(request_path, params, action) | |||
| endpoints.any? do |e| | |||
| has_id = params[:id] || params[:data].try(:[], :id) | |||
| path = request_path | |||
| if [:update, :show, :destroy].include?(context_namespace) && has_id | |||
| if [:update, :show, :destroy].include?(action) && has_id | |||
There was a problem hiding this comment.
action is passed in by the caller; seems appropriate to use it here instead of duplicating the call to context_namespace
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mitigation for a regression introduced in #447.
URI-encoded path parameters should be decoded before comparing with the (already-decoded) param.
The URI decoder is automatically set to the rails router decoder when it is detected, or
URI.decode_uri_component(Ruby >= 3.2). Users on older rubies without Rails can optionally configure it viaGraphiti.config.uri_decoder = -> (uri) { ... }(but this is only necessary if you are doing endpoint validation for routes that have percent-encoded path parameters).