-
Notifications
You must be signed in to change notification settings - Fork 4
Implement sealed-secrets namespace as ApplicationSet #1400
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Implement sealed-secrets namespace as ApplicationSet #1400
Conversation
Co-Authored-By: Chris Wessels <[email protected]>
Original prompt from Chris:
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Co-Authored-By: Chris Wessels <[email protected]>
Implement sealed-secrets namespace as ApplicationSet
This PR implements the sealed-secrets namespace as an ArgoCD ApplicationSet, migrating from the current helmfile-based approach. This is the first step in exploring the migration path from helmfile to ApplicationSets.
Changes
applicationsets
directory to store the ApplicationSet implementationsImplementation Details
The sealed-secrets namespace was chosen as the first migration target due to its simplicity:
Testing
The implementation was tested in a local kind cluster with ArgoCD installed:
kind create cluster --name argo-test
kubectl create namespace argocd && kubectl apply -n argocd -f https://raw.githubusercontent.com/argoproj/argo-cd/stable/manifests/install.yaml
kubectl apply -f applicationsets/sealed-secrets/applicationset.yaml -n argocd
Key Findings
helm.values
field must be properly formatted as a YAML string using the pipe characterCreateNamespace=true
sync option is needed to automatically create the namespaceLink to Devin run
https://app.devin.ai/sessions/2cb304d98fe04b0fb664c404b6de176f
Requested by: Chris Wessels ([email protected])