fix: update parameter order used in isAuthorized. (OZ N-05)

graphprotocol · Sep 20, 2024 · 7be3c85 · 7be3c85
1 parent 08150d3
commit 7be3c85
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/packages/horizon/contracts/data-service/utilities/ProvisionManager.sol b/packages/horizon/contracts/data-service/utilities/ProvisionManager.sol
@@ -84,7 +84,7 @@ abstract contract ProvisionManager is Initializable, GraphDirectory, ProvisionMa
      */
     modifier onlyProvisionAuthorized(address serviceProvider) {
         require(
-            _graphStaking().isAuthorized(msg.sender, serviceProvider, address(this)),
+            _graphStaking().isAuthorized(serviceProvider, address(this), msg.sender),
             ProvisionManagerNotAuthorized(msg.sender, serviceProvider)
         );
         _;

diff --git a/packages/horizon/contracts/interfaces/internal/IHorizonStakingMain.sol b/packages/horizon/contracts/interfaces/internal/IHorizonStakingMain.sol
@@ -887,5 +887,5 @@ interface IHorizonStakingMain {
      * @param verifier The verifier / data service on which they're claiming to act
      * @return Whether the operator is authorized or not
      */
-    function isAuthorized(address operator, address serviceProvider, address verifier) external view returns (bool);
+    function isAuthorized(address serviceProvider, address verifier, address operator) external view returns (bool);
 }
diff --git a/packages/horizon/test/shared/horizon-staking/HorizonStakingShared.t.sol b/packages/horizon/test/shared/horizon-staking/HorizonStakingShared.t.sol
@@ -755,7 +755,7 @@ abstract contract HorizonStakingSharedTest is GraphBaseTest {
 
         // before
         bool beforeOperatorAllowed = _getStorage_OperatorAuth(msgSender, operator, verifier, legacy);
-        bool beforeOperatorAllowedGetter = staking.isAuthorized(operator, msgSender, verifier);
+        bool beforeOperatorAllowedGetter = staking.isAuthorized(msgSender, verifier, operator);
         assertEq(beforeOperatorAllowed, beforeOperatorAllowedGetter);
 
         // setOperator
@@ -769,7 +769,7 @@ abstract contract HorizonStakingSharedTest is GraphBaseTest {
 
         // after
         bool afterOperatorAllowed = _getStorage_OperatorAuth(msgSender, operator, verifier, legacy);
-        bool afterOperatorAllowedGetter = staking.isAuthorized(operator, msgSender, verifier);
+        bool afterOperatorAllowedGetter = staking.isAuthorized(msgSender, verifier, operator);
         assertEq(afterOperatorAllowed, afterOperatorAllowedGetter);
 
         // assert