Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(SubgraphService): add current epoch to IndexingRewardsCollected… #1036

Merged
merged 2 commits into from
Sep 20, 2024

Conversation

Maikol
Copy link
Member

@Maikol Maikol commented Sep 18, 2024

… event

Copy link

openzeppelin-code bot commented Sep 18, 2024

chore(SubgraphService): add current epoch to IndexingRewardsCollected…

Generated at commit: 07bcbc062e5cd762e7ef3248137b2549b019507e

🚨 Report Summary

Severity Level Results
Contracts Critical
High
Medium
Low
Note
Total
2
4
0
15
41
62
Dependencies Critical
High
Medium
Low
Note
Total
0
0
0
0
0
0

For more details view the full report in OpenZeppelin Code Inspector

@@ -64,7 +64,8 @@ abstract contract AllocationManager is EIP712Upgradeable, GraphDirectory, Alloca
uint256 tokensRewards,
uint256 tokensIndexerRewards,
uint256 tokensDelegationRewards,
bytes32 poi
bytes32 poi,
uint256 currentEpoch
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Can we add the param explanation to the comments?

@Maikol Maikol force-pushed the mde/subgraph-service-event-change branch from 906dd64 to 07bcbc0 Compare September 20, 2024 14:47
@Maikol Maikol requested a review from tmigone September 20, 2024 14:47
Copy link
Contributor

@tmigone tmigone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌋

@Maikol Maikol merged commit 3e57ba3 into horizon Sep 20, 2024
5 checks passed
@Maikol Maikol deleted the mde/subgraph-service-event-change branch September 20, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants