Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: address typographical errors throughout codebase. (OZ N-07) #1037

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

MoonBoi9001
Copy link
Member

@MoonBoi9001 MoonBoi9001 commented Sep 18, 2024

Motivation:

Title:

N-07 Typographical Errors

Details:

Throughout the codebase, multiple instances of typographical errors were identified:

Wether should be "Whether" (also in the IRewardsIssuer contract).
poriver should be "provider".
bookeping should be "bookkeeping".
unkock should be "unlock".
Trown should be "Thrown".
Retrun should be "Return" (similarly here).
thawn should be "thawed".
verifieres should be "verifiers".
fulfulling should be "fulfilling".
delegting should be "delegating".
undelegting should be "undelegating".
stil should be "still".
Bookeeping should be "Bookkeeping".
ownsership should be "ownership".
Emmited should be "Emited".
allocationl should be "allocation".
disput should be "dispute".
Throughout the IHorizonStakingTypes interface, "inludes" should be "includes".
Throughout the Curation and L2Curation contracts, poool should be "pool".
Consider fixing the aforementioned typographical errors in order to improve the readability of the codebase.

Key changes

  • Addressed all typographical errors outlined in the audit, applying the recommended fixes.

@MoonBoi9001 MoonBoi9001 changed the base branch from main to horizon September 18, 2024 15:53
Copy link

openzeppelin-code bot commented Sep 18, 2024

fix: address typographical errors throughout codebase. (OZ N-07)

Generated at commit: 374f57d015dd6f6f0b44507e217b46193c3d1e7b

🚨 Report Summary

Severity Level Results
Contracts Critical
High
Medium
Low
Note
Total
2
4
0
15
41
62
Dependencies Critical
High
Medium
Low
Note
Total
0
0
0
0
0
0

For more details view the full report in OpenZeppelin Code Inspector

@MoonBoi9001 MoonBoi9001 requested review from tmigone, pcarranzav and Maikol and removed request for tmigone September 19, 2024 14:26
Copy link

codecov bot commented Sep 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.51%. Comparing base (4387c6c) to head (374f57d).
Report is 5 commits behind head on horizon.

Additional details and impacted files
@@           Coverage Diff            @@
##           horizon    #1037   +/-   ##
========================================
  Coverage    92.51%   92.51%           
========================================
  Files           46       46           
  Lines         2392     2392           
  Branches       428      428           
========================================
  Hits          2213     2213           
  Misses         179      179           
Flag Coverage Δ
unittests 92.51% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@tmigone tmigone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of these are incredible 😆

@MoonBoi9001 MoonBoi9001 merged commit 0438f62 into horizon Sep 19, 2024
13 of 15 checks passed
@MoonBoi9001 MoonBoi9001 deleted the fix_oz_n-07 branch September 19, 2024 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants