fix: add override keyword in functions (OZ N-09) #1039
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Title:
N-09 Missing override Keyword in Functions
Details:
Throughout the codebase, multiple instances of functions lacking the override keyword were identified:
The pause and unpause functions of the DataServicePausable contract
The pause and unpause functions of the DataServicePausableUpgradeable contract
The setRewardsDestination function of the SubgraphService contract
Functions that override the base contract functions ought to have the override keyword. Otherwise, it can be confusing for readers and developers, leading to potential misunderstandings about a function's origin and behavior. As such, consider using the override keyword for all functions that override base contract functions to enhance code readability and clarity.
Key changes