fix: remove redundant getter functions. (OZ N-15)

[MoonBoi9001]

This PR is closed, we are going to ignore OZ N-15.

Motivation:

• This PR addresses the following N-15 OZ audit issue, applying the recommended fixes.

Title:

N-15 Redundant Getter Functions

Details:

When state variables use public visibility in a contract, a getter function for the variable is automatically included.

Throughout the codebase, multiple instances of redundant getter functions were identified:

Within the ProvisionManager contract, the getDelegationRatio and the _getDelegationRatio functions are redundant. Consider removing both or combining them into a public getter.
Within the DisputeManager contract, the getDisputePeriod function is redundant.
Within the SubgraphService contract, the getAllocation function is redundant.
Within the SubgraphService contract, the getLegacyAllocation function is redundant.
Within the Allocation library, the _get function is redundant and the get function could implement its logic.
To improve the overall clarity and readability of the codebase, and save some gas at deployment, consider removing the redundant getter functions.

Review suggestion

• It might make more sense to look at the induvidual commits instead of the files changed.

Key changes

• No changes.

Ignored Suggestions

• Did not remove getDisputePeriod function.
• Did not remove the getAllocation function.
• Did not remove the getLegacyAllocationfunction.
• Did not remove the getDelegationRatio or the _getDelegationRatio functions.
• Did not remove the _get function.