TRST audit fixes for Graph Payments contracts #1072
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmigone
force-pushed
the
tmigone/trust-fixes-payments
branch
from
da0427a to
65e99f9
Compare
TRST audit fixes for Graph Payments contracts
🚨 Report Summary
For more details view the full report in OpenZeppelin Code Inspector |
…H01) Signed-off-by: Tomás Migone <[email protected]>
tmigone
force-pushed
the
tmigone/trust-fixes-payments
branch
2 times, most recently
from
d705ca6 to
7d62913
Compare
tmigone
changed the title
Signed-off-by: Tomás Migone <[email protected]>
Signed-off-by: Tomás Migone <[email protected]>
…(TRST-L10) Signed-off-by: Tomás Migone <[email protected]>
Signed-off-by: Tomás Migone <[email protected]>
Signed-off-by: Tomás Migone <[email protected]>
tmigone
force-pushed
the
tmigone/trust-fixes-payments
branch
from
7d62913 to
670fba7
Compare
…R03) Signed-off-by: Tomás Migone <[email protected]>
Maikol
approved these changes
Dec 6, 2024
Maikol
approved these changes
Dec 10, 2024
packages/horizon/test/payments/tap-collector/collect/collect.t.sol
Outdated
Show resolved
Hide resolved
packages/subgraph-service/test/subgraphService/collect/query/query.t.sol
Outdated
Show resolved
Hide resolved
Signed-off-by: Tomás Migone <[email protected]>
tmigone
force-pushed
the
tmigone/trust-fixes-payments
branch
from
89567c8 to
a065804
Compare
Maikol
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the following audit findings:
TRST-H-1 A payer could bypass the escrow mechanism and avoid paymentsTRST-M-10 A RAV could be collected more than once, leading to double paymentTRST-CL-1 A payer could bypass the escrow mechanism and avoid payments through the vulnerable collector allowance mappingTTRST-L-10 The getBalance() function could revert when balance is lower than tokens thawingTRST-M-5 Lack of chunking functionality of new RAVs may cause them to not be processableTRST-L-12 The collection cuts could exceed 100% causing collect() to revert