fix: add gns and staking counter part addresses when configuring bridge #889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #889 +/- ##
=======================================
Coverage 92.69% 92.69%
=======================================
Files 46 46
Lines 2369 2369
Branches 426 426
=======================================
Hits 2196 2196
Misses 173 173
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Going to be THAT guy, can we change this PR to use #sdk as the base branch? |
Maikol
force-pushed
the
mde/update-bridge-config
branch
from
647d4cd to
e4317e6
Compare
fix: add gns and staking counter part addresses when configuring bridge
🚨 Report Summary
For more details view the full report in OpenZeppelin Code Inspector |
tmigone
previously approved these changes
Dec 21, 2023
Maikol
force-pushed
the
mde/update-bridge-config
branch
from
e4317e6 to
7596581
Compare
tmigone
previously approved these changes
Dec 22, 2023
There was a problem hiding this comment.
I wonder if we should just delete the cli folder lol
Signed-off-by: Tomás Migone <[email protected]>
tmigone
approved these changes
Dec 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added missing configs on bridge setup, included checks in e2e tests.
counterpartGNSAddresson L1 and L2counterpartStakingAddresson L1 and L2L1GNSandL1StakingtoL1GraphTokenGateway.callhookAllowlist