Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

☀️ Graph Horizon and Subgraph Service ☀️ #944

Open
wants to merge 386 commits into
base: main
Choose a base branch
from
Open

Conversation

pcarranzav
Copy link
Member

No description provided.

Copy link

openzeppelin-code bot commented Feb 20, 2024

☀️ Graph Horizon and Subgraph Service ☀️

Generated at commit: 1038cf499a9a1fe0e8b70d1de7699f5f97e01641

🚨 Report Summary

Severity Level Results
Contracts Critical
High
Medium
Low
Note
Total
2
4
0
15
39
60
Dependencies Critical
High
Medium
Low
Note
Total
0
0
0
0
0
0

For more details view the full report in OpenZeppelin Code Inspector

@tmigone tmigone changed the title [WIP/Experimental] Horizon draft changes [WIP/Experimental] BREAKING CHANGE: Horizon draft changes Feb 20, 2024
Copy link

socket-security bot commented Feb 21, 2024

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

View full report↗︎

Copy link

codecov bot commented Feb 21, 2024

Codecov Report

Attention: Patch coverage is 87.23404% with 6 lines in your changes missing coverage. Please review.

Project coverage is 92.51%. Comparing base (eb910f0) to head (31d57b2).
Report is 47 commits behind head on main.

Files with missing lines Patch % Lines
...ges/contracts/contracts/rewards/RewardsManager.sol 80.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #944      +/-   ##
==========================================
- Coverage   92.69%   92.51%   -0.19%     
==========================================
  Files          46       46              
  Lines        2369     2392      +23     
  Branches      425      428       +3     
==========================================
+ Hits         2196     2213      +17     
- Misses        173      179       +6     
Flag Coverage Δ
unittests 92.51% <87.23%> (-0.19%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tmigone tmigone force-pushed the horizon branch 2 times, most recently from 76aa677 to 33b5790 Compare March 14, 2024 18:40
Copy link

socket-security bot commented Mar 14, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@changesets/[email protected] filesystem 0 177 kB changesets-release-bot
npm/@changesets/[email protected] environment, filesystem, shell 0 123 kB changesets-release-bot
npm/@changesets/[email protected] filesystem 0 41.3 kB changesets-release-bot
npm/@changesets/[email protected] None 0 26 kB changesets-release-bot
npm/@changesets/[email protected] None 0 9.81 kB changesets-release-bot
npm/@changesets/[email protected] None 0 18.8 kB changesets-release-bot
npm/@changesets/[email protected] filesystem 0 23.1 kB changesets-release-bot
npm/@changesets/[email protected] filesystem 0 30.4 kB changesets-release-bot
npm/@changesets/[email protected] filesystem 0 14.6 kB changesets-release-bot
npm/@commitlint/[email protected] None 0 30.6 kB escapedcat
npm/@commitlint/[email protected] None 0 18.8 kB escapedcat
npm/@commitlint/[email protected] None 0 12.2 kB escapedcat
npm/@commitlint/[email protected] None 0 13.7 kB escapedcat
npm/@commitlint/[email protected] None 0 3.97 kB escapedcat
npm/@commitlint/[email protected] None 0 13.2 kB escapedcat
npm/@commitlint/[email protected] None 0 9.11 kB escapedcat
npm/@commitlint/[email protected] None 0 14.7 kB escapedcat
npm/@commitlint/[email protected] environment, filesystem +1 71.7 kB escapedcat
npm/@commitlint/[email protected] None 0 2.81 kB escapedcat
npm/@commitlint/[email protected] None 0 4.57 kB escapedcat
npm/@commitlint/[email protected] filesystem 0 12.4 kB escapedcat
npm/@commitlint/[email protected] None 0 12.4 kB escapedcat
npm/@commitlint/[email protected] None 0 86.5 kB escapedcat
npm/@commitlint/[email protected] None 0 2.79 kB escapedcat
npm/@commitlint/[email protected] None 0 3.98 kB escapedcat
npm/@commitlint/[email protected] None 0 27.2 kB escapedcat
npm/@manypkg/[email protected] environment, filesystem +1 159 kB manypkg-release-bot
npm/@manypkg/[email protected] environment, filesystem +1 52.8 kB manypkg-release-bot
npm/@types/[email protected] None 0 96.1 kB types
npm/@types/[email protected] None 0 760 kB types
npm/@types/[email protected] None 0 2.03 MB types
npm/[email protected] eval 0 1.02 MB esp
npm/[email protected] None 0 20.2 kB ljharb
npm/[email protected] None 0 3.06 kB zkochan
npm/[email protected] None 0 15.1 kB tecfu
npm/[email protected] environment +1 36.3 kB sindresorhus
npm/[email protected] None 0 14.9 kB bcoe
npm/[email protected] filesystem 0 13.7 kB oss-bot
npm/[email protected] filesystem 0 16.1 kB oss-bot
npm/[email protected] None +1 521 kB oss-bot
npm/[email protected] None 0 12.6 kB codex-
npm/[email protected] filesystem 0 78.5 kB d-fischer
npm/[email protected] None 0 550 kB david
npm/[email protected] None 0 668 kB david
npm/[email protected] None 0 538 kB david
npm/[email protected] None 0 693 kB david
npm/[email protected] None 0 11.5 kB sindresorhus
npm/[email protected] None 0 9.68 kB sindresorhus
npm/[email protected] environment 0 189 kB jonschlinkert
npm/[email protected] None 0 2.38 MB ljharb
npm/[email protected] None 0 13.9 kB ljharb
npm/[email protected] None 0 6.61 kB vilic
npm/[email protected] filesystem 0 26.4 kB bluelovers
npm/[email protected] None 0 14.3 kB ljharb
npm/[email protected] shell +1 38.5 kB oss-bot
npm/[email protected] environment, filesystem 0 5.86 kB sindresorhus
npm/[email protected] None 0 8.4 kB safebyte
npm/[email protected] None 0 3.86 kB zkochan
npm/[email protected] None 0 2.95 kB sindresorhus
npm/[email protected] eval Transitive: environment, filesystem +1 408 kB vitaly
npm/[email protected] None 0 7.35 kB jdalton
npm/[email protected] None 0 17.7 kB jdalton
npm/[email protected] None 0 17.7 kB jdalton
npm/[email protected] None 0 21.5 kB jdalton
npm/[email protected] None 0 11.4 kB jdalton
npm/[email protected] None +2 133 kB sindresorhus
npm/[email protected] None +1 52.3 kB gar
npm/[email protected] None 0 35.1 kB cspotcode
npm/[email protected] None 0 7.24 kB sindresorhus
npm/[email protected] None +1 16.4 kB sindresorhus
npm/[email protected] None 0 5.06 kB zkochan
npm/[email protected] None +1 64.7 kB sindresorhus
npm/[email protected] None 0 3.2 kB zkochan
npm/[email protected] None 0 4.34 kB sindresorhus
npm/[email protected] Transitive: environment, filesystem +2 338 kB tecfu
npm/[email protected] Transitive: environment, filesystem, shell +3 41.7 kB thejameskyle
npm/[email protected] None 0 556 kB david
npm/[email protected] None 0 6.27 kB sindresorhus
npm/[email protected] environment, filesystem 0 49.7 kB tecfu
npm/[email protected] None 0 4.19 kB zkochan

🚮 Removed packages: npm/@aashutoshrathi/[email protected], npm/@ampproject/[email protected], npm/@ardatan/[email protected], npm/@aws-sdk/[email protected], npm/@aws-sdk/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@colors/[email protected], npm/@cspotcode/[email protected], npm/@dabh/[email protected], npm/@eslint-community/[email protected], npm/@eslint-community/[email protected], npm/@eslint/[email protected], npm/@ethersproject/[email protected], npm/@fastify/[email protected], npm/@humanwhocodes/[email protected], npm/@humanwhocodes/[email protected], npm/@isaacs/[email protected], npm/@jridgewell/[email protected], npm/@jridgewell/[email protected], npm/@jridgewell/[email protected], npm/@jridgewell/[email protected], npm/@jridgewell/[email protected], npm/@noble/[email protected], npm/@noble/[email protected], npm/@pkgjs/[email protected], npm/@pnpm/[email protected], npm/@pnpm/[email protected], npm/@pnpm/[email protected], npm/@scure/[email protected], npm/@smithy/[email protected], npm/@tsconfig/[email protected], npm/@tsconfig/[email protected], npm/@tsconfig/[email protected], npm/@tsconfig/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@typescript-eslint/[email protected], npm/@typescript-eslint/[email protected], npm/@typescript-eslint/[email protected], npm/@ungap/[email protected], npm/@yarnpkg/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected]

View full report↗︎

@tmigone tmigone force-pushed the horizon branch 4 times, most recently from 1b27dfa to cae2490 Compare March 21, 2024 20:37
@tmigone tmigone changed the title [WIP/Experimental] BREAKING CHANGE: Horizon draft changes [WIP] Horizon draft changes Apr 12, 2024
@tmigone tmigone changed the title [WIP] Horizon draft changes [WIP] Horizon changes Apr 12, 2024
@tmigone tmigone changed the title [WIP] Horizon changes [WIP] Graph Horizon May 17, 2024
Copy link
Member Author

@pcarranzav pcarranzav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments for now - still reviewing

packages/contracts/contracts/arbitrum/ITokenGateway.sol Outdated Show resolved Hide resolved
packages/horizon/README.md Outdated Show resolved Hide resolved
Copy link
Member Author

@pcarranzav pcarranzav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few more comments, still reviewing...

Copy link
Member Author

@pcarranzav pcarranzav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moar

Copy link
Member Author

@pcarranzav pcarranzav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple more comments - finished going through the main Solidity code

packages/horizon/package.json Outdated Show resolved Hide resolved
packages/subgraph-service/contracts/DisputeManager.sol Outdated Show resolved Hide resolved
@tmigone tmigone marked this pull request as ready for review June 7, 2024 23:56
@tmigone tmigone changed the title [WIP] Graph Horizon Graph Horizon and Subgraph Service Jun 7, 2024
@tmigone tmigone changed the title Graph Horizon and Subgraph Service ❄️ Graph Horizon and Subgraph Service ❄️ Jun 8, 2024
@Maikol Maikol changed the title ❄️ Graph Horizon and Subgraph Service ❄️ ☀️ Graph Horizon and Subgraph Service ☀️ Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants