[WIP] Horizon: add escrow and payments

[tmigone]

No description provided.

[openzeppelin-code]

[WIP] Horizon: add escrow and payments

Generated at commit: c052943e1f35cb97ecc6ce6e2cc96ea3fb78140b

🚨 Report Summary

	Severity Level	Results
Contracts	Critical High Medium Low Note Total	2 4 0 15 43 64
Dependencies	Critical High Medium Low Note Total	0 0 0 0 0 0

---

For more details view the full report in OpenZeppelin Code Inspector

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (horizon@7aa3798). Learn more about missing BASE report.

❗ Current head 9ab9429 differs from pull request most recent head 65157fb

Please upload reports for the commit 65157fb to get more accurate results.

Additional details and impacted files

@@            Coverage Diff             @@
##             horizon     #968   +/-   ##
==========================================
  Coverage           ?   92.70%           
==========================================
  Files              ?       46           
  Lines              ?     2370           
  Branches           ?      426           
==========================================
  Hits               ?     2197           
  Misses             ?      173           
  Partials           ?        0           

Flag	Coverage Δ
unittests	92.70% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[tmigone]

A payer could bypass the thawing by re-approving a collector for a 0 amount.

I think we should not allow re approvals for amounts that are smaller than the current allowance.

If you want to reduce the allowance it should go through the thawing period.