fix: added arbitrum sepolia to get retryable tickets #253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmigone
approved these changes
Nov 24, 2023
juanmardefago
requested changes
Nov 24, 2023
src/mappings/helpers/bridge.ts
Outdated
| } else if (addresses.network === "sepolia") { | ||
| l2ChainIdHex = "0x066EEE"; // 0x066EEE = 421614 (Arbitrum Sepolia) | ||
| } else { | ||
| log.critical('Unsupported network: {}', [addresses.network]); |
There was a problem hiding this comment.
This would break all deployments except mainnet, goerli and sepolia, since log.critical causes the subgraph to crash. If we want to give a warning or error message, please change it to log.error or log.warning
There was a problem hiding this comment.
I see, my intention was to be loud so next time we wouldn't forget to update this but we can't do that since we do deploy this to other networks. I'll update to a warning.
There was a problem hiding this comment.
Error would probably be also a decent choice if you want to make it extra obvious that something isn't expected, but given the context warning makes sense too
juanmardefago
approved these changes
Nov 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Arbitrum Sepolia network for getting retryable tickets. Included a critical log so next time we add a new chain we don't miss this step.