Make it impossible to construct an InputSchema that does not validate
#4899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lutter
force-pushed
the
lutter/validate
branch
from
27c9c3c to
e7bcd23
Compare
|
Rebase to latest master |
lutter
force-pushed
the
lutter/validate
branch
from
e7bcd23 to
a94fa3e
Compare
mangas
approved these changes
Nov 6, 2023
lutter
force-pushed
the
lutter/validate
branch
3 times, most recently
from
8d37ceb to
6719e9c
Compare
These validations only makes sense for input schemas, not generic GraphQL schemas
Since validation of InputSchema isn't mandatory, many of the schemas we use in our tests actually failed validation. This commit addresses that.
This hadn't been done before, though in practice it was probably never violated (presumably since graph-cli enforces such rules, and because trying to deploy such a schema would end badly) The `examples/validate.rs` is a tool that makes it possible to bulk validate subgraph schemas.
lutter
force-pushed
the
lutter/validate
branch
from
6719e9c to
4a16783
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With these changes, an
InputSchemais validated as soon as it is constructed, ensuring that anyInputSchemais actually valid.This PR also does:
InputSchemafromSchematoInputSchema(they were inSchemafor bad historical reasons)idfield; in practice, all schemas pass this validation, but it's good to spell the requirement out explicitlyInputSchemas; that was used on the schemas from the hosted service to make sure that all existing schemas pass the newidvalidation