Metrics for DIPS experiments #4940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
incrypto32
force-pushed
the
krishna/dips
branch
from
d614c89 to
5fa9c3f
Compare
incrypto32
commented
Nov 7, 2023
| @@ -103,7 +103,8 @@ fn ethereum_call( | |||
| abis: &[Arc<MappingABI>], | |||
| eth_call_gas: Option<u32>, | |||
| ) -> Result<AscEnumArray<EthereumValueKind>, HostExportError> { | |||
| ctx.gas.consume_host_fn(ETHEREUM_CALL)?; | |||
| ctx.gas | |||
| .consume_host_fn_with_metrics(ETHEREUM_CALL, "ethereum_call")?; | |||
There was a problem hiding this comment.
There is a macro crate function_name! https://docs.rs/function_name/latest/function_name/
Which can be potentially used here instead of hardcoding then name. Thoughts?
There was a problem hiding this comment.
The nicest would be an enum for the gas ops, but you don't need to spend time refactoring that right now.
leoyvens
approved these changes
Nov 7, 2023
| @@ -103,7 +103,8 @@ fn ethereum_call( | |||
| abis: &[Arc<MappingABI>], | |||
| eth_call_gas: Option<u32>, | |||
| ) -> Result<AscEnumArray<EthereumValueKind>, HostExportError> { | |||
| ctx.gas.consume_host_fn(ETHEREUM_CALL)?; | |||
| ctx.gas | |||
| .consume_host_fn_with_metrics(ETHEREUM_CALL, "ethereum_call")?; | |||
There was a problem hiding this comment.
The nicest would be an enum for the gas ops, but you don't need to spend time refactoring that right now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.