-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor code into indexer-common crate #53
Conversation
This is awesome, I actually just barely started working on this to share components with the " |
7a4faaf
to
aa73048
Compare
@aasseman Ok, I expect this to pass the checks. I didn't want to move the escrow monitor just yet. To avoid that, I had to split up the |
I agree on all points. The mocking was what slowed me down considerably in my attempt to split things off into a common crate this weekend. I can take a stab at the EscrowMonitor in particular in another PR. I'm the only one depending on this for now so you don't need to struggle with this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM except for 2 small things.
Also I think this should wait for #52 since this branch is based on top of it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The merge-base changed after approval.
a0def11
to
95ba473
Compare
Rebased after #52 was merged. Let's see if the tests still pass. |
service/src/server/routes/network.rs
Outdated
.json::<Value>() | ||
.await | ||
// FIXME: Don't use expect here | ||
.expect("Failed to parse network subgraph query result"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could use another bad_request_response
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, good catch. Fixed!
This moves out much of the common code into an
indexer-common
crate. The next step is likely to make more clear how one would go about implementing a different kind of indexer service.