-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor to use eventuals for allocations and signers (v2) #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 6552034814
💛 - Coveralls |
aasseman
suggested changes
Oct 12, 2023
aasseman
added
p2
Medium priority
size:x-large
Very large
type:refactor
Changes not visible to users
size:large
Large
and removed
size:x-large
Very large
labels
Oct 12, 2023
aasseman
reviewed
Oct 12, 2023
This is because the network subgraph (like all subgraphs, unfortunately) assumes that all addresses are lowercase and not checksummed. A stupid oversight from the early days.
The previous address was not present in the test allocations.
Jannis
force-pushed
the
jannis/eventuals-v2
branch
from
October 17, 2023 19:41
5ac70d3
to
5f5687e
Compare
Jannis
force-pushed
the
jannis/eventuals-v2
branch
from
October 17, 2023 19:56
ca5bc4a
to
281796f
Compare
aasseman
approved these changes
Oct 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the final PR to replace #54.
It turns allocation monitoring and attestation signer creation into eventuals, which simplifies the logic and makes it easy to chain different values that change over time together.