Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor to use eventuals for allocations and signers (v2) #65

Merged
merged 10 commits into from
Oct 17, 2023

Conversation

Jannis
Copy link
Collaborator

@Jannis Jannis commented Oct 11, 2023

This is the final PR to replace #54.

It turns allocation monitoring and attestation signer creation into eventuals, which simplifies the logic and makes it easy to chain different values that change over time together.

@Jannis Jannis marked this pull request as ready for review October 11, 2023 20:18
@github-actions
Copy link
Contributor

github-actions bot commented Oct 11, 2023

Pull Request Test Coverage Report for Build 6552034814

  • 298 of 347 (85.88%) changed or added relevant lines in 8 files are covered.
  • 4 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-1.5%) to 40.785%

Changes Missing Coverage Covered Lines Changed/Added Lines %
common/src/attestations/signers.rs 50 51 98.04%
service/src/server/mod.rs 0 2 0.0%
common/src/attestations/signer.rs 84 88 95.45%
service/src/query_processor.rs 4 10 40.0%
service/src/tap_manager.rs 0 7 0.0%
service/src/main.rs 0 14 0.0%
common/src/allocations/monitor.rs 157 172 91.28%
Files with Coverage Reduction New Missed Lines %
common/src/allocations/monitor.rs 1 91.88%
common/src/attestations/signers.rs 1 96.67%
service/src/main.rs 1 0.0%
service/src/tap_manager.rs 1 0.0%
Totals Coverage Status
Change from base Build 6519277925: -1.5%
Covered Lines: 925
Relevant Lines: 2268

💛 - Coveralls

common/src/attestations/signers.rs Outdated Show resolved Hide resolved
common/src/attestations/signer.rs Outdated Show resolved Hide resolved
@aasseman aasseman added p2 Medium priority size:x-large Very large type:refactor Changes not visible to users size:large Large and removed size:x-large Very large labels Oct 12, 2023
@Jannis Jannis force-pushed the jannis/eventuals-v2 branch from 5ac70d3 to 5f5687e Compare October 17, 2023 19:41
@Jannis Jannis force-pushed the jannis/eventuals-v2 branch from ca5bc4a to 281796f Compare October 17, 2023 19:56
Copy link
Contributor

@aasseman aasseman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@Jannis Jannis merged commit c4f6914 into main Oct 17, 2023
4 checks passed
@Jannis Jannis deleted the jannis/eventuals-v2 branch October 17, 2023 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p2 Medium priority size:large Large type:refactor Changes not visible to users
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants