Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce cost model test code #66

Merged
merged 1 commit into from
Oct 12, 2023
Merged

Reduce cost model test code #66

merged 1 commit into from
Oct 12, 2023

Conversation

Jannis
Copy link
Collaborator

@Jannis Jannis commented Oct 11, 2023

This implements @aasseman's suggestion from #63 (comment).

@Jannis Jannis requested a review from aasseman October 11, 2023 20:59
@github-actions
Copy link
Contributor

Pull Request Test Coverage Report for Build 6487934969

  • 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 43.259%
Totals Coverage Status
Change from base Build 6486820736: 0.2%
Covered Lines: 1107
Relevant Lines: 2559
💛 - Coveralls

@Jannis Jannis marked this pull request as ready for review October 12, 2023 10:32
aasseman
aasseman approved these changes Oct 12, 2023
View reviewed changes
Copy link
Contributor

@aasseman aasseman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@aasseman aasseman added size:small Small p3 Low priority type:refactor Changes not visible to users labels Oct 12, 2023
@Jannis Jannis merged commit e60c996 into main Oct 12, 2023
4 checks passed
@Jannis Jannis deleted the jannis/simplify-cost-model-tests branch October 12, 2023 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aasseman aasseman aasseman approved these changes

Assignees

@Jannis Jannis

Labels
p3 Low priority size:small Small type:refactor Changes not visible to users
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jannis @aasseman