Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fail fast when escrow accounts are missing #86

Merged
merged 1 commit into from
Nov 8, 2023

Conversation

Theodus
Copy link
Member

@Theodus Theodus commented Nov 7, 2023

Previsously, paid queries would stall until timeout while awaiting the initial eventual value for escrow accounts. This change avoids the delay, such that the intended error message is returned.

Previsously, paid queries would stall until timeout while awaiting the
initial eventual value for escrow accounts. This change avoids the
delay, such that the intended error message is returned.
@Theodus Theodus requested a review from aasseman November 7, 2023 21:35
Copy link
Contributor

github-actions bot commented Nov 7, 2023

Pull Request Test Coverage Report for Build 6790590298

  • 0 of 4 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.07%) to 50.654%

Changes Missing Coverage Covered Lines Changed/Added Lines %
common/src/tap_manager.rs 0 4 0.0%
Totals Coverage Status
Change from base Build 6755185445: 0.07%
Covered Lines: 1394
Relevant Lines: 2752

💛 - Coveralls

Copy link
Contributor

@aasseman aasseman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:
🤔 I suppose I should have used value_immediate in most places where I used value...

@Theodus
Copy link
Member Author

Theodus commented Nov 7, 2023

It seems with the org change I don't have authority to merge

@aasseman
Copy link
Contributor

aasseman commented Nov 7, 2023

It seems with the org change I don't have authority to merge

Me neither 😬

@Theodus Theodus merged commit dd6c356 into main Nov 8, 2023
5 checks passed
@Theodus Theodus deleted the theodus/integration-testing branch November 8, 2023 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants