Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: optionally override address book #818

Merged
merged 1 commit into from
Jan 23, 2024
Merged

feat: optionally override address book #818

merged 1 commit into from
Jan 23, 2024

Conversation

Theodus
Copy link
Member

@Theodus Theodus commented Nov 14, 2023

@Theodus Theodus requested a review from fordN November 14, 2023 13:22
Jannis
Jannis approved these changes Nov 14, 2023
View reviewed changes
Copy link
Contributor

@Jannis Jannis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally cool with this, but see graphprotocol/common-ts#114 (review).

fordN
fordN requested changes Nov 22, 2023
View reviewed changes
Copy link
Contributor

@fordN fordN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To work with the current latest common-ts we'll need to add functionality to read address book from file if user provides a file location

@Theodus Theodus requested a review from fordN November 22, 2023 20:33
@Theodus Theodus mentioned this pull request Jan 23, 2024
Merged
fordN
fordN approved these changes Jan 23, 2024
View reviewed changes
Copy link
Contributor

@fordN fordN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Theodus Theodus merged commit 570a01f into main Jan 23, 2024
9 checks passed
@Theodus Theodus deleted the theodus/addresses branch January 23, 2024 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gusinacio gusinacio gusinacio approved these changes

@fordN fordN fordN approved these changes

@Jannis Jannis Jannis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Theodus @Jannis @fordN @gusinacio