-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make tapSubgraph to be an optional value #904
Conversation
40d7853
to
393f16b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a quick solution, LGTM.
Longer term it'd be nice to have a cleaner solution. In particular it'd be nice to warn the indexer if we see RAVs in the DB but we don't have the right settings to act on them.
Nice, thanks for the quick fix! 🙏 There is still another backwards compatibility issue with the TAP integration though. If the indexer-agent is connected to a network without TAP contracts deployed it fails to startup: runs into an unhandled promise rejection. I'll create an issue to track and we can resolve in a subsequent PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Once it's confirmed working for an indexer without tapSubgraph configured let's get merged in.
|
GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
---|---|---|---|---|---|
12241928 | Triggered | Generic High Entropy Secret | e78f269 | network-configs/config.yaml | View secret |
12251296 | Triggered | Generic High Entropy Secret | e78f269 | network-configs/config.yaml | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
edd5f83
to
9aefd87
Compare
8d0719c
to
68e8165
Compare
68e8165
to
fb48c7c
Compare
Signed-off-by: Carlos V <[email protected]>
Signed-off-by: Carlos V <[email protected]>
fb48c7c
to
e78f269
Compare
Ford found out tapsubgraph is not an optional value so changed a few things to make it work