Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for parse body when sending files with multipart #6

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

paulefoe
Copy link

@paulefoe paulefoe commented Aug 25, 2018

Recently I tried to send files with multipart and came across the issue where graphql told me that I'm sending an empty query.
I am using apollo-upload-client to send files and I saw that it's indeed sends the query with all necessary parameters, but graph couldn't parse it correctly.
The reason is that this client send the query in the key 'operations' where value is json.
I don't know if they changed it recently, but since it's official client for uploading files with graphql, I think this should be fixed.
I would like to write a tests for it as well, but I think they are kinda broken, at least I couldn't make them run.
Hope to hear from you, thanks for a great library.

@wumpus
Copy link

wumpus commented Apr 27, 2019

It would be nice if this was merged. For Flask usage one of my current projects uses https://github.com/lmcgartland/graphene-file-upload perhaps it could be useful for comparing implementations ? Definitely better to have this part of this package and not an extension of an extension.

@paulefoe
Copy link
Author

@wumpus I don't think that this will be merged no matter the implementation. However, we've been using my fork for some internal project at my company. There is a bug for when you uploading big files. It's not crucial for our use case but if you consider using my fork, I can definitely fix it.

@wumpus
Copy link

wumpus commented Apr 28, 2019

graphene-file-upload extends Flask+graphl, perhaps you could study how it works and then release this code as a separate project?

I'd use this code for uploading images and short videos, is that big enough to be buggy with your code? Ought to be relatively easy to fix if it is easy to trigger the bug in testing.

@Cito Cito force-pushed the master branch 2 times, most recently from 6a8d7be to 21a6753 Compare January 24, 2020 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants