Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce cognitive complexity and typo fixes #1457

Open
wants to merge 21 commits into
base: main
Choose a base branch
from
Open
Changes from 1 commit
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
ad447d9
Remove unnecessary if statement
lilac-supernova-2 Aug 26, 2023
0e1b605
Keep 'if' above same as before, fix lint issue
lilac-supernova-2 Aug 26, 2023
cd6e042
Fix Star Wars spaceship name
lilac-supernova-2 Aug 26, 2023
ea77bc7
Fix some typos in comments
lilac-supernova-2 Aug 26, 2023
6580228
Rename filename with typo
lilac-supernova-2 Aug 26, 2023
1b00e67
Update import
lilac-supernova-2 Aug 26, 2023
5c52096
Snake case fixes
lilac-supernova-2 Aug 26, 2023
2a888ac
Add possibly missing import of DjangoFilterConnectionField
lilac-supernova-2 Aug 26, 2023
b639034
Actually, let's not do this to avoid circular imports
lilac-supernova-2 Aug 26, 2023
d873220
Remove nesting for readability
lilac-supernova-2 Aug 26, 2023
67373c7
Rename function
lilac-supernova-2 Aug 26, 2023
722daf1
Typo fixes
lilac-supernova-2 Aug 26, 2023
34e61c6
More typo fixes
lilac-supernova-2 Aug 26, 2023
988b308
Refactor get_filtering_args_from_filterset into more functions to red…
lilac-supernova-2 Aug 26, 2023
cb92d6e
Add new tests-repeat command to Makefile to be able to run unit tests…
lilac-supernova-2 Aug 26, 2023
19d5558
Add 'self' argument
lilac-supernova-2 Aug 26, 2023
34db851
Snake case formatting fix
lilac-supernova-2 Aug 26, 2023
98fd498
Refactor validation function to reduce complexity
lilac-supernova-2 Aug 26, 2023
a94a89d
Linting
lilac-supernova-2 Aug 26, 2023
59c0117
Refactor execute_graphql_request function to reduce complexity
lilac-supernova-2 Aug 26, 2023
e263840
Linting
lilac-supernova-2 Aug 26, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add possibly missing import of DjangoFilterConnectionField
  • Loading branch information
lilac-supernova-2 authored Aug 26, 2023
commit 2a888ac993b897e657a850aaaf579dc365aa8bfa
1 change: 1 addition & 0 deletions graphene_django/filter/filters/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
from .list_filter import ListFilter
from .range_filter import RangeFilter
from .typed_filter import TypedFilter
from ..filters import DjangoFilterConnectionField

__all__ = [
"DjangoFilterConnectionField",
Expand Down