Fix Performance Issues #228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
abhinand-c
commented
Dec 9, 2023
abhinand-c
commented
- fix: union type naming for mongo_fields having inner mongo_field
- fix: union type naming convention
- fix: wrong sync to async wrapper being used
- fix: await not called on len
- fix: Blocking code removed, and reduce has_next_page DB calls
- fix: lint issues
eg: field_1 = ListField(GenericLazyReferenceField(choices=[X1,X2])) generates type ModelNoneUnionType This fix will make it ModelField1UnionType
AsyncUnionType -> UnionType
# TODO: cleanup logics
# Conflicts: # graphene_mongo/fields_async.py # graphene_mongo/types.py
Bump from released version number
abhinand-c
force-pushed
the
fix-performance
branch
from
474abee to
a091a72
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.