Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add database session to the example #249

Merged
merged 4 commits into from
Oct 6, 2023

Conversation

clemens-tolboom
Copy link
Contributor

Coming from https://docs.graphene-python.org/projects/sqlalchemy/en/latest/tutorial/ as a python noob I failed to run their example but could fix this example by adding the database session.

Coming from https://docs.graphene-python.org/projects/sqlalchemy/en/latest/tutorial/ as a python noob I failed to run their example but could fix this example by adding the database session.
@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.343% when pulling 1a418a6 on clemens-tolboom:patch-1 into 0544f81 on graphql-python:master.

@codecov-commenter
Copy link

codecov-commenter commented Apr 28, 2022

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (d0668cc) 96.39% compared to head (e9b5e38) 96.39%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #249   +/-   ##
=======================================
  Coverage   96.39%   96.39%           
=======================================
  Files           9        9           
  Lines         915      915           
=======================================
  Hits          882      882           
  Misses         33       33           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

README.md Show resolved Hide resolved
@erikwrede erikwrede merged commit f5f05d1 into graphql-python:master Oct 6, 2023
19 checks passed
@erikwrede
Copy link
Member

Better late than never - thanks for your contribution 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants