Update reqwest to latest version ^0.12 #490
Conversation
graphql_client/Cargo.toml
Outdated
| @@ -20,10 +20,14 @@ serde_json = "1.0" | |||
|
|
|||
| # Optional dependencies | |||
| graphql_query_derive = { path = "../graphql_query_derive", version = "0.14.0", optional = true } | |||
| reqwest-crate = { package = "reqwest", version = "^0.11", features = ["json"], default-features = false, optional = true } | |||
| reqwest11-crate = { package = "reqwest", version = "^0.11", features = ["json"], default-features = false, optional = true } | |||
| reqwest-crate = { package = "reqwest", version = "^0.12", features = ["json"], default-features = false, optional = true } | |||
There was a problem hiding this comment.
We should only have versioned feature flags — since the reqwest upgrade is a breaking change, updating it in the feature flag is a breaking change. I think it's fine because this crate is not 1.0, but we should start prefixing everything. So if that's ok, we could have reqwest11 and reqwest12 features for future proofing.
This comment was marked as off-topic.
This comment was marked as off-topic.
There was a problem hiding this comment.
Given that no code is changed for this version bump, would it be possible to support both versions with a version range?
reqwest = { version = ">=0.11, <=0.12", features = ["json", "blocking"] }
I could provide a PR for a CI job that builds the minimal dependency versions if that is appreciated.
Not possible, below 1.0, the second component of the version is a major version. |
|
CI is not running, will have to figure that out first. |
|
I don't know why the errors aren't showing up on the PR page, but it looks like clippy isn't passing. |
Why is that not possible? I do something similar in As I understand, |
|
Hmm interesting, that's new to me. We would need to test with all these versions to check for build failiures, but if that works, that may be a solution. I still think the approach in this PR is more straightforward. |
I think running CI jobs requires approval of a maintainer for this repo. https://docs.github.com/actions/managing-workflow-runs/approving-workflow-runs-from-public-forks |
No description provided.