Skip to content

Commit

Permalink
review feedback
Browse files Browse the repository at this point in the history
Co-authored-by: Jovi De Croock <[email protected]>"
  • Loading branch information
yaacovCR committed Dec 1, 2024
1 parent ecbaa78 commit 1d5b240
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions src/execution/values.ts
Original file line number Diff line number Diff line change
Expand Up @@ -226,6 +226,7 @@ export function experimentalGetArgumentValues(
// execution. This is a runtime check to ensure execution does not
// continue with an invalid argument value.
throw new GraphQLError(
// TODO: clean up the naming of isRequiredArgument(), isArgument(), and argDef if/when experimental fragment variables are merged
`Argument "${isArgument(argDef) ? argDef : argDef.name}" of required type "${argType}" was not provided.`,
{ nodes: node },
);
Expand Down Expand Up @@ -276,6 +277,7 @@ export function experimentalGetArgumentValues(
valueNode,
argType,
(error, path) => {
// TODO: clean up the naming of isRequiredArgument(), isArgument(), and argDef if/when experimental fragment variables are merged
error.message = `Argument "${isArgument(argDef) ? argDef : argDef.name}" has invalid value${printPathArray(
path,
)}: ${error.message}`;
Expand Down

0 comments on commit 1d5b240

Please sign in to comment.