Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

polish: improve addDeferredFragments readability #3966

Merged
merged 1 commit into from
Sep 4, 2023

Conversation

yaacovCR
Copy link
Contributor

@yaacovCR yaacovCR commented Sep 3, 2023

-- improve variable naming:

parentDeferUsage => parentTarget
deferUsage => newDeferUsage

-- add comments

-- improve variable naming `parentDeferUsage` => `parentTarget`, `deferUsage` => `newDeferUsage`
-- add comments
@yaacovCR yaacovCR added the PR: polish 💅 PR doesn't change public API or any observed behaviour label Sep 3, 2023
@yaacovCR yaacovCR requested a review from robrichard September 3, 2023 12:53
@netlify
Copy link

netlify bot commented Sep 3, 2023

Deploy Preview for compassionate-pike-271cb3 ready!

Name Link
🔨 Latest commit e0d7ba4
🔍 Latest deploy log https://app.netlify.com/sites/compassionate-pike-271cb3/deploys/64f481d81fc55700081b3990
😎 Deploy Preview https://deploy-preview-3966--compassionate-pike-271cb3.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions
Copy link

github-actions bot commented Sep 3, 2023

Hi @yaacovCR, I'm @github-actions bot happy to help you with this PR 👋

Supported commands

Please post this commands in separate comments and only one per comment:

  • @github-actions run-benchmark - Run benchmark comparing base and merge commits for this PR
  • @github-actions publish-pr-on-npm - Build package from this PR and publish it on NPM

@yaacovCR yaacovCR merged commit d32b99d into graphql:main Sep 4, 2023
20 checks passed
@yaacovCR yaacovCR deleted the add-comments branch September 4, 2023 16:37
@yaacovCR yaacovCR changed the title polish: addDeferredFragments polish: improve addDeferredFragments readability Sep 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: polish 💅 PR doesn't change public API or any observed behaviour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants