Skip to content

only make NewDefaultServer once when neccessary #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 1, 2025

Conversation

greedy52
Copy link

@greedy52 greedy52 commented Apr 1, 2025

reapply #1 with sync.OnceValue

before:

stevehuang@mac ~/go/github.com/gravitational/teleport/lib/srv/db/mysql (master) $ GODEBUG='inittrace=1' go test  2>&1 | grep "go-mysql\/server"
init github.com/go-mysql-org/go-mysql/server @41 ms, 188 ms clock, 1528944 bytes, 13261 allocs

after:

stevehuang@mac ~/go/github.com/gravitational/teleport/lib/srv/db/mysql (master) $ GODEBUG='inittrace=1' go test  2>&1 | grep "go-mysql\/server"
# github.com/go-mysql-org/go-mysql/server
init github.com/go-mysql-org/go-mysql/server @35 ms, 0.019 ms clock, 792 bytes, 26 allocs

@greedy52 greedy52 requested a review from rosstimothy April 1, 2025 15:11
@greedy52 greedy52 self-assigned this Apr 1, 2025
Copy link

@rosstimothy rosstimothy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Steve! Is there any reason that we are using teleport-v1.9.1 as the base branch for our changes in this repo? Our typical pattern for forks is to use master/main to track and pull in upstream changes, and to use teleport as the default branch for our custom tweaks.

@greedy52 greedy52 merged commit 63fa74e into teleport-v1.9.1 Apr 1, 2025
20 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants