Require capitalizing "Access (List|Request)" #40599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #38767 Standardize the docs on capitalizing features and major components of Teleport. Edit the vale rule for capitalizing service names to include features as well, and require capitalizing "access list" and "access request". Also sort the list of tokens in the vale rule.
|
@zmb3 This is based on consulting with @travelton |
|
The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with |
ptgott
added
the
no-changelog
ryanclark
approved these changes
Apr 17, 2024
Responds to ryanclark feedback
zmb3
approved these changes
Apr 22, 2024
public-teleport-github-review-bot
bot
removed the request for review
from fheinecke
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #38767
Standardize the docs on capitalizing features and major components of Teleport. Edit the vale rule for capitalizing service names to include features as well, and require capitalizing "access list" and "access request".
Also sort the list of tokens in the vale rule.