Change default keyboard shortcuts #41818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
avatus,
ibeckermayer,
kimlisa,
ptgott,
r0mant,
rudream,
ryanclark,
xinding33 and
zmb3
gzdunek
commented
May 21, 2024
| newTerminalTab: 'Ctrl+Shift+T', | ||
| closeTab: 'Ctrl+Shift+W', | ||
| newTab: 'Ctrl+Shift+T', | ||
| newTerminalTab: 'Ctrl+Shift+`', |
There was a problem hiding this comment.
This shortcut matches vscode.
gzdunek
removed request for
r0mant,
ryanclark,
ibeckermayer,
xinding33,
kimlisa and
rudream
|
🤖 Vercel preview here: https://docs-e5clbpmc0-goteleport.vercel.app/docs/ver/preview |
avatus
approved these changes
May 21, 2024
zmb3
approved these changes
May 21, 2024
gzdunek
added
the
no-changelog
|
🤖 Vercel preview here: https://docs-68fj5ucol-goteleport.vercel.app/docs/ver/preview |
ravicious
approved these changes
May 24, 2024
… allow linter find the 'Configuration' heading The angle brackets seem to be interpreted as HTML tags.
|
🤖 Vercel preview here: https://docs-dpvc3jedv-goteleport.vercel.app/docs/ver/preview |
|
🤖 Vercel preview here: https://docs-jp50031ku-goteleport.vercel.app/docs/ver/preview |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #41207.
I've looked at vscode, tabby, Windows Terminal and the Ubuntu terminal and I see that they usually use
Ctrl+Shift+*orCtrl+Alt+*for shortcuts. I decided to change ours toCtrl+Shift+*since they are more popular. I also looked at the bash and nano shortcuts and we shouldn't conflict with them now.I was thinking about changing the
Ctrl+1 - Ctrl+9shortcuts on Windows toCtrl+Shift+1 - Ctrl+Shift+9to match Windows Terminal, but they don't cause conflicts, so I left them intact.