Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v15] Reduce tsh binary size #41975

Merged
merged 1 commit into from
May 24, 2024
Merged

[v15] Reduce tsh binary size #41975

merged 1 commit into from
May 24, 2024

Conversation

rosstimothy
Copy link
Contributor

@rosstimothy rosstimothy commented May 23, 2024 •
edited
Loading

Backport #41743 to branch/v15

A local build compared to branch/v15:

ls -lah ~/src/teleport/build/
total 398568
drwxr-xr-x@  4 tim  staff   128B May 24 10:30 ./
drwxr-xr-x@ 81 tim  staff   2.5K May 24 10:30 ../
-rwxr-xr-x@  1 tim  staff    88M May 24 10:30 tsh-backport-41743/v15*
-rwxr-xr-x@  1 tim  staff   107M May 24 10:29 tsh-v15*

@rosstimothy rosstimothy added backport no-changelog Indicates that a PR does not require a changelog entry labels May 23, 2024
@rosstimothy rosstimothy changed the title Reduce tsh binary size [v15] Reduce tsh binary size May 23, 2024
@rosstimothy rosstimothy force-pushed the tross/backport-41743/v15 branch from 1899a2f to c2c8c2a Compare May 23, 2024 20:32
@rosstimothy
Reduce tsh binary size (#41743)
4f044a1 
* Remove lib/web dependency from tsh

Refactors the terminal stream code in lib/web into a subpackage
so that tsh no longer depends on the entire lib/web package.

* Remove lib/auth dependency from tsh

Refactors invalid credentials errors and helpers into lib/auth/authclient
so that tsh no longer imports lib/auth directly.

* fix find-replace typos
@rosstimothy rosstimothy force-pushed the tross/backport-41743/v15 branch from c2c8c2a to 4f044a1 Compare May 24, 2024 13:55
@rosstimothy rosstimothy marked this pull request as ready for review May 24, 2024 14:33
@github-actions github-actions bot requested review from probakowski and zmb3 May 24, 2024 14:33
@github-actions github-actions bot added desktop-access size/sm tsh tsh - Teleport's command line tool for logging into nodes running Teleport. labels May 24, 2024
@public-teleport-github-review-bot public-teleport-github-review-bot bot removed the request for review from probakowski May 24, 2024 20:20
@rosstimothy rosstimothy added this pull request to the merge queue May 24, 2024
Merged via the queue into branch/v15 with commit 10d0f05 May 24, 2024
36 of 37 checks passed
@rosstimothy rosstimothy deleted the tross/backport-41743/v15 branch May 24, 2024 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcoandredinis marcoandredinis marcoandredinis approved these changes

@zmb3 zmb3 zmb3 approved these changes

Assignees
No one assigned
Labels
backport desktop-access no-changelog Indicates that a PR does not require a changelog entry size/sm tsh tsh - Teleport's command line tool for logging into nodes running Teleport.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rosstimothy @marcoandredinis @zmb3