Add plugin resource handling in tctl #42059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smallinsky
force-pushed
the
smallinsky/plugin_create_update
branch
from
5c50143 to
6739756
Compare
|
The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with |
smallinsky
force-pushed
the
smallinsky/plugin_create_update
branch
2 times, most recently
from
38f6110 to
29fdc9a
Compare
tigrato
reviewed
May 28, 2024
r0mant
approved these changes
May 28, 2024
smallinsky
force-pushed
the
smallinsky/plugin_create_update
branch
from
ff9602b to
b54b653
Compare
capnspacehook
approved these changes
May 29, 2024
|
@smallinsky See the table below for backport results.
|
This was referenced May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Add support for plugin resource in tctl.
Note: Plugin resource uses oneof with gogo proto that produce incompatible object using jsonpb and native json encoder.
To support this a customer pluginResourceWrapper was introduced.
changelog: Add support plugin resource in tctl tool