Add session recording access format to audit event #47307
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of adding usage metrics for session recording access. This PR adds the field
format
to the audit event. Possible values arejson
,yaml
,text
, andpty
.To receive the value, we have to update the calls of
StreamSessionEvents
to receive an additional argument (format
). This function emits the audit event but can be called in different scenarios (depending on the requested format). In some places, this new attribute won't be used; however, it is still required, given that we use the same interface.changelog: Include the
format
field on thesession.recording.access
audit event with the format in which the recording was accessed.