Cache node_modules in Lint (Docs)
#48073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
ptgott
force-pushed
the
paul.gottschling/2024-10-29-node-cache
branch
5 times, most recently
from
3f2a00e to
dd38d43
Compare
ptgott
requested review from
klizhentas,
russjones,
r0mant,
zmb3,
fheinecke,
camscale,
tcsc,
rosstimothy and
codingllama
as code owners
ptgott
force-pushed
the
paul.gottschling/2024-10-29-node-cache
branch
from
dd38d43 to
afffe64
Compare
zmb3
approved these changes
Oct 29, 2024
public-teleport-github-review-bot
bot
removed request for
ryanclark,
capnspacehook and
atburke
ptgott
added
the
no-changelog
The `Lint (Docs)` GitHub Actions workflow spends the most time installing NodeJS dependencies. Cache these dependencies across workflow runs to reduce runtime. Use the `actions/cache` workflow with `node_modules`. With this approach, `Lint (Docs)` runs go from around 10-11m to around 5 minutes. This approach caches `node_modules` instead of the the yarn cache, since yarn needs to build fresh packages even when it copies files from the yarn cache into node_modules.
ptgott
force-pushed
the
paul.gottschling/2024-10-29-node-cache
branch
from
afffe64 to
3232235
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Lint (Docs)GitHub Actions workflow spends the most time installing NodeJS dependencies. Cache these dependencies across workflow runs to reduce runtime. Use theactions/cacheworkflow and add configuration based on the workflow's documentation for Yarn.