[v17] Allow including Access Lists as nested members and owners #48312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
backport
size/md
tctl
r0mant
approved these changes
Nov 1, 2024
smallinsky
approved these changes
Nov 1, 2024
public-teleport-github-review-bot
bot
removed the request for review
from fspmarshall
kiosion
force-pushed
the
maxim/v17/nested-accesslists
branch
from
83fcec6 to
923103e
Compare
- Recursively check for accesslist membership - Allow adding/removing/listing included access lists in acl commands - Add a recursive test - Use dynamic access lists structure from RFD - Resolve proto changes - Exclude 'list' members from Access List memberCount - Calc Access List member count with members of type 'list' excluded, return seperately to front end - Update examples/integrations - Update crd docs - Update tf docs - Perform calculation of inherited roles/traits to AccessList service in order to utilize cache and minimize number of requests. - Grant Okta integration RO for Access Lists - Update AccessListMember-* events - Include count for inherited grants - Include MembershipKind of affected member(s) - Emit inherited grants / members' MembershipKind for AccessListMember-* events - Update notified owners for Access Requests - Ensure dynamic owners are notified for Access Requests - Ensure dynamic owners are notified via Slack integration - Optionally pass an AbortSignal to `fetchAccessLists` in Web UI - Replace usages of `services.IsAccessListOwner/IsAccessListMember` with equivelant funcs from `Hierarchy` - Remove final references to AccessListMembershipChecker - Don't allow ACL deletion when member/owner in other lists - Guard Access List deletion behind membership/ownership checks for List - Expose Hierarchy func to recursively get all members - Tidy UserLoginStateGenerator logic involving ACL Membership/Ownership
kiosion
force-pushed
the
maxim/v17/nested-accesslists
branch
from
923103e to
1f89379
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #38738 for v17.
changelog: Allow nested inclusion of Access Lists as Members and Owners in other Access Lists