ensure ca caches include correct revision #48481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fspmarshall
added
no-changelog
bernardjkim
approved these changes
Nov 5, 2024
rosstimothy
approved these changes
Nov 5, 2024
|
@fspmarshall See the table below for backport results.
|
This was referenced Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
UpsertCertAuthoritymethod was skipping writes if the substantive content of a CA resource was unchanged. This worked fine before the introduction of revisions and atomic writes, but it is now common for items to have their revision change without their spec changing, and common for conditional operations to rely on the revisions present in the cache.This problem was brought to light because the recent changes to
UpsertTrustedCluster(#48009) made this issue much more likely to be hit, though we have a number of places where revisions/atomics were already used with CAs so its likely that this has been a problem for a while.Fixes #48330
changelog: fixed an issue where modifying trusted clusters and/or cert authorities could result in a spurious "concurrent update" error.