-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Azure resource fetching in the Discovery service #48843
Draft
mvbrock
wants to merge
31
commits into
master
Choose a base branch
from
mvbrock/azure-integration-fetch
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvbrock
force-pushed
the
mvbrock/azure-integration-grpc
branch
3 times, most recently
from
November 14, 2024 19:52
6c2c286
to
7d10b7c
Compare
mvbrock
force-pushed
the
mvbrock/azure-integration-fetch
branch
from
November 18, 2024 20:35
6e1c97f
to
4c2df44
Compare
mvbrock
force-pushed
the
mvbrock/azure-integration-grpc
branch
from
November 18, 2024 20:38
7d10b7c
to
61e626b
Compare
mvbrock
force-pushed
the
mvbrock/azure-integration-fetch
branch
2 times, most recently
from
November 18, 2024 23:37
dae5182
to
b20ff8b
Compare
… and role name to role definitions
mvbrock
force-pushed
the
mvbrock/azure-integration-fetch
branch
from
December 2, 2024 18:40
9f7e308
to
a3b84e8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of of https://github.com/gravitational/access-graph/issues/640 to implement Azure resource fetching in the Discovery service, and originating from the Azure integration POC branch master...mvbrock/azure-integration-poc. This PR is dependent on #48628 which specifies the gRPC messages/methods for transmitting Azure resources to the Access Graph. A new Azure fetcher is introduced alongside the AWS fetcher, as well as the addition of Azure role definition/assignment clients in the Cloud library, per https://github.com/gravitational/access-graph/issues/1314.