Use thread-local RNGs for jitters #48860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
espadolini
added
no-changelog
github-actions
bot
added
audit-log
github-actions
bot
requested review from
bernardjkim,
greedy52,
hugoShaka,
tigrato and
timothyb89
espadolini
force-pushed
the
espadolini/rand-v2-jitters
branch
from
1564a86 to
e4e6b86
Compare
rosstimothy
approved these changes
Nov 13, 2024
public-teleport-github-review-bot
bot
removed request for
timothyb89,
tigrato,
bernardjkim,
greedy52,
hugoShaka and
fspmarshall
tigrato
approved these changes
Nov 13, 2024
|
@espadolini See the table below for backport results.
|
espadolini
removed
kubernetes-access
audit-log
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces the use of allocated RNGs for jitters with
math/rand/v2's thread-localInt64N. In synthetic benchmarks this seems to result in a x100 speedup compared to both old uncontended and contended but sharded implementations.Commits after the first are the result of mechanical refactoring consisting of progressive inlining of functions and package-level variables.
Functions in the
apimodules have been left in place, but rendered harmless; the two functions inlib/utilsare there to support the enterprise module until it's updated.