add teleport version to SubmitEventRequest #49248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GavinFrazar
added
the
no-changelog
marcoandredinis
approved these changes
Nov 20, 2024
creack
approved these changes
Nov 20, 2024
GavinFrazar
force-pushed
the
gavinfrazar/add-version-to-error-reporting
branch
from
8211412 to
f98184d
Compare
|
i'll wait for the cloud change to be released before merging backports. |
avatus
approved these changes
Nov 22, 2024
public-teleport-github-review-bot
bot
removed request for
espadolini and
fspmarshall
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
@GavinFrazar See the table below for backport results.
|
This was referenced Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on cloud PR: https://github.com/gravitational/cloud/pull/11219
Part of our efforts to triage web ui resource enrollment wizard errors is narrowing in on the version of Teleport that was running when an error occurred. This PR adds the teleport cluster (auth server) version to the event request we submit to prehog, which will add it as a property to the posthog event:
tp.teleport_version.