Get rid of math/rand in favor of math/rand/v2
#49294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
bernardjkim,
greedy52,
hugoShaka,
probakowski,
rosstimothy and
tigrato
github-actions
bot
added
audit-log
zmb3
approved these changes
Nov 20, 2024
bernardjkim
approved these changes
Nov 20, 2024
public-teleport-github-review-bot
bot
removed request for
tigrato,
probakowski,
greedy52,
hugoShaka and
rosstimothy
tigrato
approved these changes
Nov 21, 2024
espadolini
added
no-changelog
|
@espadolini See the table below for backport results.
|
espadolini
added a commit
that referenced
this pull request
Nov 21, 2024
* Get rid of math/rand in favor of math/rand/v2 * Update retryutils to use rand.N * Update e ref
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 21, 2024
* Get rid of math/rand in favor of math/rand/v2 * Update retryutils to use rand.N * Update e ref
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces all uses of
math/randwithmath/rand/v2save for a test that's currently using a fixed seed and what seems to be fixed inputs; all other occurrences of dedicatedmath/randsources used with nondeterministic inputs or using the time as a seed were replaced with the appropriate globalmath/rand/v2construction orcrypto/rand.Should wait for (and include) gravitational/teleport.e#5542