Preparation for variable rate heartbeats #49433
Open
+760
−508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 1e2d772.
espadolini
added
no-changelog
zmb3
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces the
MultiIntervalused by the inventory controller with a lightweight wrapper around atime.Timerthat doesn't make use of goroutines, gets rid of "control log" inventory pings (as the control log mechanism is not sound given the changes to instance heartbeats, and since nothing uses it, there's no reason to exercise it) so we no longer need a method to trigger instance heartbeats from the outside of the inventory, removes an unstable envvar that disables heartbeat keepalives (the largest setup we know of didn't end up needing it) and prepares the inventory controller to make use of variable rate heartbeats, which are going to be per-protocol in a later PR (that will likely not get backported, unlike this one).