Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update CA rotation docs #49468

Merged
merged 1 commit into from
Feb 27, 2025
Merged

docs: update CA rotation docs #49468

merged 1 commit into from
Feb 27, 2025

Conversation

nklaassen
Copy link
Contributor

@nklaassen nklaassen commented Nov 26, 2024

This PR updates the CA rotation to mention the new interactive tctl auth rotate (#49171).

Copy link

🤖 Vercel preview here: https://docs-f3a9rw882-goteleport.vercel.app/docs

Copy link
Contributor

@ptgott ptgott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some initial feedback


CA rotations can be **manual** or **semi-automatic**. In manual mode, admins
must instruct the Teleport Auth Service to advance from one phase to the next.
Between phases, admins can prepare their infrastructure to adjust to each
change. In semi-automatic mode, the Teleport Auth Service cycles through each
phase automatically, with a grace period between each phase.

In 17.1.0+ `tctl auth rotate` (with no arguments) starts an interactive
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this change, we mention tctl auth rotate after the manual and semi-automatic options. Would it make sense to structure the guide around the wizard instead, and leave the documentation of the arguments for our reference guides (i.e., this guide would be the fast path)? Otherwise, while the argumentless form of tctl auth rotate is a simplification, the documentation actually becomes a little more complex.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can see some benefits to pushing the interactive command, though I worry that relying only on arguments in the reference guides might leave too much as an exercise to the reader.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ptgott i haven't been finding the time to come back to this and rewrite with an interactive-first guide. If what he have here is a net improvement do you think we can merge as-is?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Friendly ping @ptgott.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To expedite this, I would open a separate PR containing only the new tctl auth rotate changes. That way, we can finalize the wording of the other changes and decide on a structure for this guide that is easier to make sense of.

Copy link

🤖 Vercel preview here: https://docs-e5day2a2e-goteleport.vercel.app/docs

Copy link

github-actions bot commented Jan 23, 2025

Amplify deployment status

Branch Commit Job ID Status Preview Updated (UTC)
nklaassen/rotate-docs 9be9163 2 ✅SUCCEED nklaassen-rotate-docs 2025-02-25 23:20:03

@nklaassen nklaassen requested a review from ptgott January 23, 2025 22:33
@nklaassen
Copy link
Contributor Author

I decided to remove most of the unrelated changes from this PR and just include a couple mentions of the new interactive CA rotation

@public-teleport-github-review-bot public-teleport-github-review-bot bot removed the request for review from r0mant February 27, 2025 22:06
@nklaassen nklaassen added this pull request to the merge queue Feb 27, 2025
Merged via the queue into master with commit 0d4953d Feb 27, 2025
43 checks passed
@nklaassen nklaassen deleted the nklaassen/rotate-docs branch February 27, 2025 22:37
@public-teleport-github-review-bot

@nklaassen See the table below for backport results.

Branch Result
branch/v17 Create PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/branch/v17 documentation no-changelog Indicates that a PR does not require a changelog entry size/sm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants