-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: update CA rotation docs #49468
Conversation
🤖 Vercel preview here: https://docs-f3a9rw882-goteleport.vercel.app/docs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some initial feedback
|
||
CA rotations can be **manual** or **semi-automatic**. In manual mode, admins | ||
must instruct the Teleport Auth Service to advance from one phase to the next. | ||
Between phases, admins can prepare their infrastructure to adjust to each | ||
change. In semi-automatic mode, the Teleport Auth Service cycles through each | ||
phase automatically, with a grace period between each phase. | ||
|
||
In 17.1.0+ `tctl auth rotate` (with no arguments) starts an interactive |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this change, we mention tctl auth rotate
after the manual and semi-automatic options. Would it make sense to structure the guide around the wizard instead, and leave the documentation of the arguments for our reference guides (i.e., this guide would be the fast path)? Otherwise, while the argumentless form of tctl auth rotate
is a simplification, the documentation actually becomes a little more complex.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can see some benefits to pushing the interactive command, though I worry that relying only on arguments in the reference guides might leave too much as an exercise to the reader.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ptgott i haven't been finding the time to come back to this and rewrite with an interactive-first guide. If what he have here is a net improvement do you think we can merge as-is?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Friendly ping @ptgott.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To expedite this, I would open a separate PR containing only the new tctl auth rotate
changes. That way, we can finalize the wording of the other changes and decide on a structure for this guide that is easier to make sense of.
🤖 Vercel preview here: https://docs-e5day2a2e-goteleport.vercel.app/docs |
c713ea4
to
07e58cb
Compare
Amplify deployment status
|
07e58cb
to
9be9163
Compare
I decided to remove most of the unrelated changes from this PR and just include a couple mentions of the new interactive CA rotation |
@nklaassen See the table below for backport results.
|
This PR updates the CA rotation to mention the new interactive
tctl auth rotate
(#49171).