[v17] Add request.reason.mode to role conditions (proto only) #49494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes the proto type (+validation) only to declutter the original PR #49124 The real changes are in - api/proto/teleport/legacy/types/types.proto - api/types/access_request.go - lib/auth/auth_with_roles.go - lib/auth/auth_with_roles_test.go The rest is all generated.
kopiczko
force-pushed
the
kopiczko/backport-49256-branch/v17
branch
from
0a7e8a0 to
0f92851
Compare
|
🤖 Vercel preview here: https://docs-q8nv9gqew-goteleport.vercel.app/docs |
github-actions
bot
requested review from
hugoShaka,
marcoandredinis,
r0mant,
smallinsky and
tigrato
kopiczko
added
the
no-changelog
marcoandredinis
approved these changes
Nov 27, 2024
tigrato
approved these changes
Nov 27, 2024
public-teleport-github-review-bot
bot
removed request for
r0mant,
hugoShaka and
smallinsky
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #49256 to branch/v17