autoupdate: reconcile rollout status and add strategy interface #49735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 3, 2024
hugoShaka
added
the
no-changelog
sclevine
approved these changes
Dec 5, 2024
vapopov
approved these changes
Dec 5, 2024
| // config_start_hour to initiate update | ||
| int32 config_start_hour = 7; | ||
| // config_wait_days after last group succeeds before this group can run. This can only be used when the strategy is "halt-on-failure". | ||
| int64 config_wait_days = 9; |
There was a problem hiding this comment.
nit: int64 config_wait_days = 8;
hugoShaka
force-pushed
the
hugo/rollout-progress-common
branch
from
8c41768 to
06d909d
Compare
r0mant
approved these changes
Dec 6, 2024
public-teleport-github-review-bot
bot
removed request for
probakowski and
Joerger
hugoShaka
force-pushed
the
hugo/rollout-progress-common
branch
from
06d909d to
296b736
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First PR implementing automatic update progress driven by the auth server.
The PR might look large but it only has ~250 lines of code, the rest of the diff is caused by large table tests and generated content.
To make review a bit easier I only added the
rolloutStrategyinterface in the PR. Two PRs will follow implementing the time-based and halt-on-error strategies.I also added new fields to the rollout status groups in order to track the initial rollout config. Currently the rollout is created with a config and does not change, even if the user edits the schedules. I will address this in a subsequent PR, very likely by adding a rollout status reset call.
Also, the client will still reject versions using the regular schedule, I will life the restriction once we have a working regular schedule and both strategies implementations are merged.
Part of: RFD-184
Goal (internal): https://github.com/gravitational/cloud/issues/10289