[v16] Fix flaky integration tests caused by prometheus metrics conficts #51206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ct (#48296) * Fix flaky test because of prometheus metrics: blackhole metrics * lint
hugoShaka
added
the
no-changelog
hugoShaka
changed the title
rosstimothy
approved these changes
Jan 17, 2025
tigrato
approved these changes
Jan 17, 2025
public-teleport-github-review-bot
bot
removed request for
zmb3,
strideynet and
GavinFrazar
zmb3
reviewed
Jan 18, 2025
| @@ -126,6 +128,7 @@ func TestTCTLTerraformCommand_ProxyJoin(t *testing.T) { | |||
| func TestTCTLTerraformCommand_AuthJoin(t *testing.T) { | |||
| t.Parallel() | |||
| testDir := t.TempDir() | |||
| prometheus.DefaultRegisterer = metricRegistryBlackHole{} | |||
|
|
|||
There was a problem hiding this comment.
Is this safe to do in a parallel test?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manual backport of #48248 to
branch/v16due to minimal conflicts.Fixes: #44944