[vnet] gprc service protos #51215
Merged
[vnet] gprc service protos #51215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nklaassen
added
no-changelog
ravicious
approved these changes
Jan 23, 2025
| // Hash specifies a cryptographic hash function. | ||
| enum Hash { | ||
| HASH_UNSPECIFIED = 0; | ||
| HASH_NONE = 1; |
There was a problem hiding this comment.
When is HASH_NONE used? It might be worth adding a comment about this, I'm not sure (or refer to another place which explains this).
There was a problem hiding this comment.
it's used for Ed25519 signature which do no pre-hash, added a comment
rosstimothy
approved these changes
Jan 23, 2025
public-teleport-github-review-bot
bot
removed the request for review
from kopiczko
|
@nklaassen See the table below for backport results.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds protos for the VNet client application service, to be used for Windows support, based on RFD 195