Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

render water sport facilities (non waterpark) #2018

Closed
HolgerJeromin opened this issue Jan 11, 2016 · 7 comments · Fixed by #3422
Closed

render water sport facilities (non waterpark) #2018

HolgerJeromin opened this issue Jan 11, 2016 · 7 comments · Fixed by #3422

Comments

@HolgerJeromin
Copy link
Contributor

We should render leisure=sports_centre + sport=swimming same as the current leisure=water_park to prevent tagging for the renderer (for not fun orientated water stuff).
All keys are available in the database.

The sports_centre + swimming combination is quite often used (Taginfo says 3272) even now.

@polarbearing
Copy link
Contributor

leisure=water_park still lacks area rendering #1490, being a candidate for a new boundary style #1624.

@matkoniecz
Copy link
Contributor

taginfo link: https://taginfo.openstreetmap.org/tags/leisure=sports_centre#combinations (3420 as of 2016-03-04).

@ghost
Copy link

ghost commented Jan 8, 2018

@matkoniecz: Here's the link to the discussion on the tagging mailing list about swimming pool facilities: https://lists.openstreetmap.org/pipermail/tagging/2017-September/subject.html#33466.

Copied from #2870:

The result from the discussion on the tagging mailing list is that public indoor as well as outdoor swimming facilities should be tagged leisure=sports_centre + sport=swimming and that leisure=water_park should only be used for real water parks (amusement parks featuring slides, wave pools etc.).

Therefore I think it would be best to use the swimmer icon for leisure=sports_centre + sports=swimming (#2018) and to change the icon for leisure=water_park for a water slide or similar (as one doesn't swim there).

Current use of leisure=sports_centre + sports=swimming: 8 028

@geozeisig
Copy link

We have now revised the water sports in the wiki and cleaned up. There are four features that should have an icon:

  1. leisure=water_park has now
    swimming-16
    This is misleading and should be changed. For example, in a water slide or a person in the water playing the ball.

  2. leisure=sports_centre + sport=swimming should have the following icon:
    swimming-16

  3. leisure=swimming_area + sport=swimming should have the following icon:
    swimming-16

  4. amenity=public_bath we have now:
    public_bath
    that's OK

@HolgerJeromin
Copy link
Contributor Author

  1. leisure=swimming_area + sport=swimming

Wiki makes the sport tag optional

@geozeisig
Copy link

@HolgerJeromin Thanks for the hint. At leisure=swimming_area it is already clear from the word that it is sport=swimming. So I change my suggestion:

  1. leisure=swimming_area should have the following icon:
    swimming-16

@Tomasz-W
Copy link

related to #844

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants