Good first issues [meta-ticket]

[Tomasz-W]

Regularly updated task list:

single icons:

• amenity=boat_rental Add icon for amenity=boat_rental #3263 -> done! Add icon for boat_rental #3300
• amenity=bureau_de_change Add icon for amenity=bureau_de_change #3185 -> done! Add icon for Bureau_de_change #3301
• shop=charity; second_hand Add special rendering for shop=charity #1869 -> done! Add icon for charity and second_hand and update department_store icon #3302
• shop=interior_decoration Add special rendering for shop=interior_decoration #1406 -> done! Add icon for shop=interior_decoration #3293
• shop=video Add icon for shop=video #3116 -> done! Add icon for shop=video #3313
• leisure=bowling_alley Add bowlings #3297 -> done! Add icon for leisure=bowling_alley #3311
• shop=paint Add special icon for shop=paint #3288 -> done! Add icon for shop=paint #3323
• shop=massage Add special icon for shop=massage #3287 -> done! Add icon for shop=massage #3309
• leisure=outdoor_seating Add icon for leisure=outdoor_seating #3241 -> done! Add icon for leisure=outdoor_seating #3328
• leisure=bird_hide Add icon for leisure=bird_hide #3175 -> done! Add icon for leisure=bird_hide #3340
• shop=bookmaker Add icon for shop=bookmaker #3186 -> done! Add icon for shop=bookmaker #3345
• shop=trade Add icon for shop=trade (and potentially shop=wholesale) #3291 -> done! Add special icon for shop=trade, shop=wholesale #3361
• man_made=storage_tank/ silo Suggestion for man_made=storage_tank #588 man_made=silo is not being rendered #2909 -> done! Add icons for man_made=storage_tank, man_made=silo #3384
• orthodox cross add orthodox cross for religion=christianity icon (depending on denomination) #1186 -> closed
• leisure=amusement_arcade Render leisure=amusement_arcade #3371 -> done! Add rendering for arcades #3375
• amenity=bicycle_repair_station Add rendering for amenity=bicycle_repair_station #3069 -> done! Add icon for bicycle repair station, update car repair icon #3391
• tourism=gallery Add rendering for tourism=gallery #883 -> done! Add icon for tourism=gallery #3401
• amenity=vehicle_inspection Render amenity=vehicle_inspection #3378 -> done! add icon for amenity=vehicle_inspection #3434
• amenity=internet_cafe Add amenity=internet_cafe icon #3451 -> done! Render amenity=internet_cafe #3463
• man_made=telescope Render man_made=telescope #3389 -> done! Render man_made=telescope telescope:type=radio #3473
• amenity=public_bookcase Please render amenity=public_bookcase #1288 -> done! Add icon for amenity=public_bookcase #3462
• leisure=fishing Add rendering for leisure=fishing #3390 -> done! add icon for leisure=fishing #3508
• shop=fabric/ carpet/ sewing Add special icon for shop=fabric #3289 -> done! Add icons for shop=fabric and carpet #3555

sets of icons:

• memorials Distinguish different memorial types #3088 -> done! Add icons for memorial subtags #3356
• healthcare objects Unified rendering of healthcare objects #2938 -> done! Add rendering for healthcare tag scheme #3498
• crane Add rendering for man_made=crane #3478 -> done! Add rendering for man-made cranes #3501 -> cranes Distinguish different cranes types #3573 -> closed :(

[Tomasz-W]

Further goals:

• update some icons files Pixel aligning some icons #3362 -> done! Pixel aligning some icons  #3383
• update some icons Update some icons #3449 -> done! Update some icons #3533
• lighter icons for private POIs render more private POI icons lighter #1012 -> done! Add rendering for private POI #3528

labels (names) rendering:

• generator:source=wind Names for wind turbines #2734 -> done! Render Wind Turbines names, Change icon to gray, Do not render before z19 if location is rooftop #3515
• tourism=attraction (areas) Add area render for tourism=attraction #1257 -> closed :(

ways rendering:

• attraction=water_slide Add rendering for water slides (attraction=water_slide) #3335 -> done! Water slide #3346
• leisure=track Rendering leisure=track on lines #2632 -> done! Add rendering for leisure=track on lines #3443
• aerialway=magic_carpet Add rendering of aerialway = magic_carpet #3169 -> closed

areas fillings rendering:

• man_made=wastewater_plant Add rendering for man_made=wastewater_plant #717 -> done! Add rendering of man_made=wastewater_plant, water_works #3376

rendering change:

• gastronomy key colour Change gastronomy objects colour to orange #3329 -> done! Change gastronomy objects to orange color #3360
• amenity area fill colour New landuse=farmland rendering color too close of amenity=hospital #1991 -> done! Change societal amenities color #3412
• aeroway=apron Apron color in aerodromes is too prominent #3385 -> done! Change color for apron in aerodromes #3444
• natural=scrub Stream is barely visible on scrub #2098 -> done! Change scrub color and pattern #3529

[lakedistrictOSM]

@Tomasz-W Have you thought about writing an osm.org Diary Entry or /r/openstreetmap post to see if there's anyone who's able to do the coding and testing for these prepared icons? :)

[Martin-Lbg]

I might help in coding, but since I never coded anything for OSM, I would need some instructions. I'm able to program in general and I'm willing to learn OSM-methodolgy - but got stuck in the vast amount of different actions needed (at least it Looks that way to me). Where could I start?

[kocio-pl]

Great!

Two links that work for most of the newcomers are:

https://wiki.openstreetmap.org/wiki/Standard_tile_layer
https://github.com/gravitystorm/openstreetmap-carto/blob/master/DOCKER.md

If you however will need some help, just ask here.

[Tomasz-W]

here you are: https://www.openstreetmap.org/user/Tomasz_W/diary/44420

[Adamant36]

Random issues that need code or testing (Not endorsed by or affiliated with Tomasz-W or his lists):

• natural=mud renders differently in rivers #1547 - Rendering of natural=mud in rivers
• Bus stops should have priority over shelters #2431 - Shelters rendering over bus stops
• Not liking bluish color for Pedestrian Streets/areas #2691 - Bluish color for Pedestrian Streets/areas
• Less prominent spring icons at lower zoom levels #3274 - Prominence of spring icons at lower zoom levels
• Add rendering of aerialway = magic_carpet #3169 - Rendering of aerialway = magic_carpet
• Add rendering for barrier=bollard when applied to a way #3073 - Rendering for barrier=bollard when applied to a way
• Zoom level for hamlet #1984 - Zoom level for hamlet
• Pedestrian crossings not visible #1943 - Pedestrian crossings not visible
• access=private/access=no roads shouldn't be rendered as regular roads at any zoom level #1889 - Rendering as access=private/access=no as regular roads
• Render brand=* for amenity=fuel #1874 - Render brand=* for amenity=fuel
• natural=mud renders differently in rivers #1547 - Natural=mud renders differently in rivers
• Inconsistent priorities of region/city names at levels 5 and 6+ #3034 - Inconsistent priorities of region/city names at levels 5 and 6+
• Quarry similar to residential landuse #2905 - Quarry similar to residential landuse
• Skipping parts of bigger objects on lower zoom levels #2896 - Skipping parts of bigger objects on lower zoom levels
• Waterway's name render is inconsistent.  #2411 - Waterway's name render is inconsistent
• Consider level=* #1977 - Consider level=*
• fountain rendering problems #1934 - Fountain rendering problems
• housenumbers on non-buildings areas aren't rendered #1746 - Housenumbers on non-buildings areas aren't rendered
• Highway = platform is too strong on zoom 16  #1659 - Highway = platform is too strong on zoom 16
• swimming_pool outlines too noisy #585 - Swimming_pool outlines too noisy
• Render underground buildings different #552 - Render underground buildings different
• Please add name rendering for landuse=religious #3322 - Add name rendering for landuse=religious

[Tomasz-W]

@Adamant36 When we have 300+ issues and small amount of coders, we have to set some priorities. I think we should go from the easiest issues to more complicated ones. As there is ~30 issues just in first "phase" I think thah adding more complicated ones there will make mess.

[Adamant36]

@Tomasz-W I dont disagree. I never said they needed to be added now or that the simpler tasks cant be done first. So feel free to add them after the simpler ones are done. At least they are there in the mean time though if someone wants give them a try.

[kocio-pl]

For me it's just a @Tomasz-W list - he's doing some managing things at the moment, so it's up to him how he does like to do it. I'm happy to see people involved in different activities, because we need not only coders. This list is a social tool helping newcomers to start - it looks that they feel more welcome this way, so we just go with it.

That being said, I try to not stick to just one type of things. Sometimes I do some trivial fixes to just relax a bit within a project and have some fast reward, because that's encouraging, but we have also some big challenges that are important and I also treat them as priority, but at the moment nobody is working on them (see https://github.com/gravitystorm/openstreetmap-carto/projects).

[Tomasz-W]

I just want to inform some of previous contributors that we still need coders for further map developing. Please take a look at the first two posts in this issue (#3298 (comment) #3298 (comment)). Maybe there will be something that you will be interested in writing code for. We need YOU! :)

@skylerbunny @d3d9 @hikemaniac @vnbhattarai @MKuranowski @jnachtigall @systemed @boothym @davidfg4 @PissedCapslock @sarxos @mojodna @tmcw @derickr @DeeHants @AurimasF @micechal @CloCkWeRX @Rovastar @chrisfleming @mstock @wonderchook @mackerski @tyrasd @smsm1 @M1dgard @ubahnverleih @littlebtc @doktorpixel14 @jbelien @MattBlissett @Firefishy @woodpeck @kaldari @erictheise @AndrewHain @jdhoek @tpikonen @altoing @Zverik @HolgerJeromin @micahcochran @andrzej-r @Penegal @kreed @vholten @StyXman @floscher @mrwojo @danstowell @Ircama @dkniffin @ian29

[systemed]

@Tomasz-W please don't spam people's mentions like that, seriously not cool

[Tomasz-W]

list of issues closed without test renderings, when there was still some people interested in showing them:

• amenity=coworking_space Add rendering for amenity=coworking_space #1628
• chess tables Add icon for chess tables #3039
• leisure=bleachers Add rendering for leisure=bleachers #3140

[Adamant36]

@Tomasz-W You might want to go through and revise your list at the top. It seems like a few of them aren't at the "code needed" stage yet.

[Tomasz-W]

@Adamant36 Actually it's a list of issues where we need a test renderings at least, to decide what's next with it (rate readability of the icon on map etc.). Doing the same thing in PRs is also ok and it makes the process faster, so I prefer PRs.

[Adamant36]

The name of the issue is "Code Needed to Rendered Prepared Icons" and it seems like the list isn't at that point anymore. Since most of the icons that are "prepared" have already merged and most things either need test rendering now or more debate. So can you at least update the title to reflect that the issue about that anymore? It might be a minor thing, but it would still be nice.

I totally agree with you on PRs. They have the advantage of going faster in a lot of cases. A lot of the unsolved issues here that are stuck in debate could probably be dealt with if someone just did PRs for them. Even if they aren't perfect solutions.

[Adamant36]

@Tomasz-W (or anyone else) what do you think the priorties are at this point and what would you like to see me (or anyone else) work on next? Im feeling pretty good about the stuff we have gotten done so far but im not sure whats worth focusing on now.

[Tomasz-W]

My personal favourities at the moment are #3326 (I hope with #3187), #3143 + #2098, and #2086 . I'm waiting for most of icons from first post, but I'm not going to copy-paste here whole list, I would be happy if any of them will be pushed forward.

[Adamant36]

Alright. The backrest one clearly isnt going to happen, but I think the other ones are doable hopefully. Just expect more of an uphill battle for more things to be rendered after that though.

[Tomasz-W]

@Adamant36 It would be also good to finish abandoned #3135 and #3126. It looks like @james2432 left it.

[Adamant36]

Good call. Those have been bugging me for a while now. I'll work on them next. Id love to see more of the stagnate PRs get dealt with. If you see any other ones that could can be finished I'd be willing to do it.

[Adamant36]

You think I should wait on craft until the color and #3395 is worked out? It doesnt seem like the color has been decided yet. Maybe I could do some test renderings of different colors or something in the mean time if nothing else.

[Tomasz-W]

@Adamant36 I think that better way is to firstly see a test renderings with different colours, and then discuss and choose the best colour. If we reverse it, it's just a discussion of certain people's imaginations of something,

[boothym]

@Adamant36 also if you are doing test renderings, it would be great to see what railway=disused looks like on z14, which would be an easy fix to solve this issue: #2074 (comment) 👍

[Adamant36]

@Tomasz-W, when we get a few issues completed can you start a new, similar issue that combines all the issues that are left in your various lists? As it is, this issue is getting messy and buried under other issues. Id like it to be more prominent and easier to find for the new coders that are coming along. Plus, its a becoming a hassle for me to sift through. Thanks.

[jeisenbe]

I also think a few of the meta-issues should be broken into parts. The "natural=" issue #788 includes fjords, valleys, ridges & aretes. Those should be 3 different PRs

…

On Fri, Oct 5, 2018 at 10:16 AM Adamant36 ***@***.***> wrote: @Tomasz-W <https://github.com/Tomasz-W>, when we get a few issues completed can you start a new, similar issue that combines all the issues that are left in your various lists? As it is, this issue is getting messy and buried under other issues. Id like it to be more prominent and easier to find for the new coders that are coming along. Plus, its a becoming a hassle for me to sift through. Thanks. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#3298 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AoxshJLIrjUP0Wl2UhrHmgKscDs_xyeEks5uhrL7gaJpZM4VLmJ2> .

[Adamant36]

@jeisenbe, I agree. I've been thinking about doing a PR for ridges for a while now but didn't want to do the other ones with it. So breaking it up would be good. The same goes for sport. Especially now that there is a PR for swimming.

A few of the PRs like craft probably would have been done already if it didn't involve 20 different things in the same PR. I much rather see things get implemented at a slow drip pace then not at all. So, generally, the more we can split things up the better. Since it makes it a lot easier on everyone to keep track of, do the coding, test etc.

[Tomasz-W]

@Adamant36 I have a plan to open new ticket with task list from second post when all from the first one will be done. We can't close/ open some tickets just because they are lost in issues jungle, if we start bevaving like this, another users will start to close/ open tickets for the same reason and this mess would become even larger. If it is easier for coders to split PRs into smaller pieces, they should do it, but issues are something different and from my observation splitting issues into smaller pieces makes things worse (discussion usually becomes some unreadable web of references and mentions then)

Please add this link to your bookmarks, it should help you: https://github.com/gravitystorm/openstreetmap-carto/issues?q=is:issue+is:open+sort:updated-desc (issues sorted by last updates, it make things easier)

[Adamant36]

@Tomasz-W, however you want to do it. A few of the issues in the first list have stalled out though and I don't see them getting done any time soon if ever. Like the horse racing one. So hopefully if there is a few left that won't be done for a while it won't dissuade you from creating a new issue.

As far as creating multiple issues for things goes, I agree with you in principle. It depends on the issue though. The sport issue already has off branching issues and multiple conversation strands/references (like rendering lines on pitches when the issue is about icons). So do other issues like #788 (which involves two clearly separate topics, how to render ridges and also if ocean names should be rendered as dots or not). Splitting them in the first place would have helped. For me, its more about encouraging people to split up new issues if possible going forward then doing it proactively. Also, we should encourage people more to create a new issue when the conversation goes off track but is still working on at some point (sports lines for instance). That way, good ideas that might not be addressed right then wont just get lost in the melee. Plus, its makes PRs a lot easier. A lot of times I don't give a rational for a PR unless I am asked for one just because I don't want to sift through a years worth of messages that are only vaguely related to each other, if at all, to figure out why the PR should be implemented. Or I'll just pass over issues that have to many parts. It might be the only one that does that, but either way, whatever we can do to make things easier for possible contributors the better I say.

Anyway, thanks for the link. I didn't know there was a special page for that. I'll have to bookmark it instead of the main page.

[Tomasz-W]

@Adamant36 Speaking about issues from first post: they all need at least test renderings (to rate different icon designs or decide do we need any icon ), so "stalled out" discussion is propably caused by lack of them. I know it might be uncomfortable for you to work on something which can be never merged, but it's the price of fair and productive cooperation. There are many icons designed by me which was rejected, but I don't find working on them as a waste of time. Trying different things and testing them is a part of discussion, so if there was some users interested in adding some feature, there are no new comments, but there is also no test renderings, you shouldn't consider it as a finished discussion.

I'm very satisfied with last few months of development, when you was working on listed issues one by one. If you would like to work on next ones by splitting it into smaller PRs feel free to do it (just remember about adding "related to" words instead of "closes" before issue number in PR first post). I'll take care of lefting information for another users that only a part of some issue was resolved, so don't worry ;)

[Adamant36]

Ok. Its mostly a matter of time. Ive been really busy with school the last month. So im trying to pick things here to do when I have the time that will be productive. Plus, I'm just not much for all the debating thats happening lately. Its not really my strong suit. I much rather just be in the weeds coding and testing things. The good thing about a lot of the issues I worked on before was that they were mostly settled. So the discussion was minimal on them. It seems like we have mostly ran out of those types of issue though.
I plan to do the sport icons when the swimming PR gets merged and I still need to do the testing etc on the other PRs I have going. I guess I dont mind things I work on not getting merged, but it is a time investment. Yeah, it can be disapointing if it happens, but I know thats life. Most of the time I learn way more from the things that fail on here then the ones that succeed. So, I guess its worth my time either way.

Anyway, thanks for the pep talk. You make some good points. Plus, I appreciate that you'll update issues if I only resolve part of them. That would help a lot ;)

[Adamant36]

Btw, can you see whats going on with the horse icon issue and try to work it out so I can add it to the sports issue when I work on it? Both issues are pretty high on my priority list. I guess I could do the rest of the sports icons without it, but id like it to be in there if possible.

[lakedistrictOSM]

@jeisenbe @Adamant36 I've suggested that #3148 is reopened so that it can be done separately from #788, if any of you would like to do it. :)

[Adamant36]

@Tomasz-W, id like to see a new clean issue that incorporates issues from my list and your further objectives list. So it might be worth starting a new one now since 99% of the issue in the first post are either done, PR's, or closed and not going anywhere. Plus, there is some done on your further objectives list also.

It would save a lot of time with scrolling and sifting through closed/done/PRed issues.

[kocio-pl]

Maybe you need a wiki to not scroll and rewrite tickets all the time? GitHub has such a module for projects, you should ask @gravitystorm to switch it on then.

[Adamant36]

Sounds like a solid idea. You should do that @Tomasz-W.

[Tomasz-W]

@Adamant36 I promise I will open fresh one at the end of 2018. As I said before, I'm against starting 'close & open' repeated issues in random time behaviour, because I'm worried that then people will start do it in mass "because everybody forgot about my ticket", at the other hand I think that idea of opening new year with refreshed version of this overloaded meta-issue would be a good excuse for making an exeption ;)

[Adamant36]

That works. I was actually thinking that to. I can defer my irritation about it for another month ;)

[kocio-pl]

I have just changed the name of this ticket to better fit the place for pinned issues.

[Adamant36]

@kocio-pl, thank's for pinning it. It makes it a lot easier to find.

@Tomasz-W, you want to strike out issue #1257 since its been closed? Also "lighter icons for private POIs #1012 -> PR #3528" can be checked off since its been merged. Along with "amenity=public_bookcase #1288."

"barriers #3122" can be struck out also since its closed.

[Tomasz-W]

@Adamant36 Thanks for noticing! I've updated the list.

PS. Small change - I'll open new version of this ticket in a first days of 2019 as I want to write a little summary of our work in 2018.

[kocio-pl]

No problem - when you open new version, I will just pin it instead of this one.

[Tomasz-W]

Big thanks for all involved in, especially coders! ❤️ As this issue began to be overloaded, I'm opening new one.

Please continue further discussion in #3617.