Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render trees before streets #2665

Closed
ftrebien opened this issue Jun 27, 2017 · 11 comments
Closed

Render trees before streets #2665

ftrebien opened this issue Jun 27, 2017 · 11 comments

Comments

@ftrebien
Copy link

Trees placed close to streets end up rendered on top of them, sometimes resulting in something similar to this. Some examples include here in Paris and here in Berlin.

Regardless of whether trees are being mapped as intended, I think trees are more relevant at high zoom levels, in which they usually don't overlap with streets. So it's probably safe to render them before streets, at least at lower zoom levels. What do you think?

The same logic probably applies to tree rows too, like here in Amsterdam. It seems that mappers have tried to work around this by mapping tree rows as forest areas, like here.

@imagico
Copy link
Collaborator

imagico commented Jun 27, 2017

Trying to give a bit of context here: We deliberately draw roads in an abstract width which is wider than they are in reality at all but the highest zoom levels. Same also applies to trees and tree rows. Doing this is normal in maps but usually requires moving the objects (a process called Verdrängung in German - not sure if there is an exact equivalent term in English). We can't do that because it is technically difficult to do so automatically and it would severely affect mapper feedback - hence we inevitable get overlaps. This is not specific to roads and trees, we also get this with lots of other stuff.

I think as a general rule we should in such cases preferably draw the smaller objects above the larger ones - which in this case as it is currently rendered and which is also kind of the intuitive order - unless there is a bridge trees are located above roads.

With a different drawing order you would also end up with partial trees which are difficult to interpret for the map user (what does a green half circle symbolize again?)

@Circeus
Copy link

Circeus commented Jul 5, 2017

This is really a debate on the zoom level at which trees ought to be displayed (cf. issue #838 ). There's going to be complain no matter the zoom level.

@ftrebien
Copy link
Author

ftrebien commented Jul 6, 2017

Interesting. Maybe one possible solution is to make trees (and tree rows) fainter at zoom level 17 (like in OSM-FR) and fainter still - or not rendered at all - at level 16.

@matkoniecz
Copy link
Contributor

a process called Verdrängung in German - not sure if there is an exact equivalent term in English

In Poland it seems to be considered as part of something that has English name "cartographic generalization".

@matkoniecz
Copy link
Contributor

I also think that the only thing that can be done here is too make trees fainter/smaller/invisible on list zoom levels, changing order is going to introduce more hard interpret symbols.

@matthijsmelissen
Copy link
Collaborator

matthijsmelissen commented Aug 21, 2017

Maybe one possible solution is to make trees (and tree rows) fainter at zoom level 17 (like in OSM-FR) and fainter still - or not rendered at all - at level 16.

+1. Trees are currently too prominent, with more and more areas with all trees added.

@matkoniecz
Copy link
Contributor

And maybe it would be feasible to show important trees earlier (name, maybe also things like presence of tags like tourism=attraction or Wikipedia tag - though it is tricky, denotation tag is not too useful and physical size is not helpful at all).

@matkoniecz
Copy link
Contributor

+1. Trees are currently too prominent, with more and more areas with all trees added.

@matthijsmelissen Can you (or anybody else) give an example of areas where trees are too prominent? I looked at example from #2665 (comment) (the initial post) and everything seems fine to me.

@matthijsmelissen
Copy link
Collaborator

https://www.openstreetmap.org/#map=18/49.62184/6.15306

@dieterdreist
Copy link

dieterdreist commented Apr 24, 2018 via email

@jeisenbe
Copy link
Collaborator

Closing, we had several comments against this idea. However, there was support for rendering trees smaller at the lower zoom levels, so that idea could be tried as a PR or opened as a new issue.

@jeisenbe jeisenbe removed this from the Bugs and improvements milestone Nov 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants