-
Notifications
You must be signed in to change notification settings - Fork 819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Push some small amenities to higher zoom level #1745
Comments
Is getting the money less important than spending it? I am not sure. |
I think about proportions: the counterpart for shops is rather bank or post office IMO. ATM or post box are less important than them. Similar case: amenity=recycling+recycling_type=centre are bigger/more important > amenity=recycling+recycling_type=container and amenity=waste_disposal are in between > trash cans are the least important. Another progression of scale: monument > memorial sculpture > memorial plaque. There can be also many other such things - for example we already show supermarkets/malls etc earlier than convenience shops. |
Mockup with atm, post_box, telephone pushed from z17 to z18 (and emergency_phone to z19, as this is highly specialized kind of amenity): I also think about moving them to the low priority group. Another amenities that could be probably moved further down the zoom level and/or prioritized as less important could be toilettes and drinking_water, but I am not sure about them yet. |
Given the density of post boxes, I don't think they should be moved from z17 to z18. |
It's not about density of post boxes alone - they just add up to the whole density, as you can see, like other small amenities. They are clearly less important than post offices, so in my opinion it's perfectly legit to push them +1 zoom level. In many places they are of less interest for general public (it's not a map mainly for tourists anyway) and there is a special issue about objects in rural areas, where every POI is more important than in the city/town/village, so post boxes should be more visible there (maybe even more than now - we'll see). |
I think pnorman meant there are only postboxes every 1000 meter (in Germany). |
Yes, I have understood it this way too - does it sound like I haven't? In other words: I realize that their density is low, but there are other POIs on the map and the sum of all the elements can be dense (as on the example picture) and it makes sense to clear the things (even a bit) if we can. Those small elements tend to be placed around some more important ones, so they don't just take unused space, they rather make busy places even more busy. BTW: do we have levels of importance or just normal/low groups? I think it would be the best to have more layers - post box may be less important than post office or a shop, but is more important than trash can. |
+1 |
Detailed technical question: how should I create amenity-medium-priority group? I see that in project.yaml group with id ORDER BY prio
) AS amenity_low_priority but I don't understand how it is used then to find the real priority level? Maybe we don't need additional group, because this line: CASE WHEN amenity='waste_basket' THEN 2 ELSE 1 END AS prio is the core information (the more number, the lower priority) and I could give 3 to waste_basket, 2 for current low priority objects and 1 for those small amenities? Of course I understand I need to also edit amenity-points.mss file. |
The name of the table in the SQL ( The id The "priority" is determined by rendering order, i.e. where the layer is relative to other layers. Within the layer, the order rows are returned in is what determines rendering order, as well as cartocss order. |
Yes. |
I'm waiting for #1825 to be applied (and maybe also for #1802 (comment)), but the code is more or less ready and it's working as expected: global density change is not visible, but in some places it's getting more clear and the overall view is more uniform (smaller amenities don't mix with standard ones on z17 and ATMs should not eclipse banks on any zoom level). |
Another candidate for moving deeper: barrier=bollard should be rendered on z>=19 in my opinion. It also means some other small amenities could be rendered there:
They are also used to be a part of bollard line. |
barrier=bollard is very important kind of barrier that makes road impassable for cars. It should be rendered earlier not later. However, there are some bollards which are not part of the road. These could be rendered at z19. |
Thanks for the comment, it makes a lot of sense! Is there a way to detect in this style if the bollard is part of the road? |
It should be possible. See turning circles - I think that currently only ones on highway ways are displayed. |
Currently it is visible from z16 I guess, which zoom level would you like to have as the starting one? |
http://www.openstreetmap.org/#map=19/33.05398/-96.69600 seems to show that On Sun, Sep 13, 2015 at 1:19 PM, Mateusz Konieczny <[email protected]
|
I guess highway=traffic_signals are also smaller amenities, so they should be moved to z>=18 instead of z>=17 (which is better for standard amenities). |
Now I think traffic_signals should be moved to z>=19, since they are not the even the small amenities worth looking for, rather part of a road infrastructure. |
Note that some ideas were declined in #1884. |
@kocio-pl would you consider returning to this issue? Maybe #1884 could be split in smaller tasks. I'd be very interested in moving bollards (the ones that don't belong to a highway) to z19 as they tend to mess up the map at z16-z17: |
Feel free to do it yourself. I can join the party, but I won't do it alone. |
I would like to get back to this issue - the summary of a rejected PR was:
Would it make sense to create separate PRs for these 3 types to be rendered from z18? I still don't know how to push bollards to z19+ only if they are not part of highway, but I think this should not create controversy. Can anybody help me with this? |
Just a reminder to myself: there's a separate issue for loose bollards and hint how to do it (#2756). |
Just for sort things out - there are 4 tags left in this issue:
|
@kocio-pl @Adamant36
|
@Tomasz-W, thanks. Amenity=post_box is currently an issue though, not a PR. Although, I guess I could have done one for it. |
@Adamant36 Oh, I see now. I think that splitting PRs into smaller parts is OK, but I find splitting issues (at least this one) unnecessary for the reason given in #3298 (comment) . |
@Tomasz-W, Good call, even if I disagree. I took the original comment by @kocio-pl about it as a possible suggestion and not a part of the issue. Since he didn't include it in the ATM PR. I guess that's part of the problem with not having unified way of doing things. Issues, lists in issues (sometimes referencing other issues, with their own lists), PRs, lists of PRs, PRs with lists of issues, etc, etc. It can easily turn into inception sometimes ;) |
@Adamant36
|
Tomasz-W, did you happen to see issue #2665 about trees? Maybe it can be added to the list. At higher zoo. levels they do kind of clutter the map up and effect rendering in some places. Especially where they are over mapped. Oh yeah, do you have any good examples of places where amenity=drinking_water and amenity=telephone are an issue? What about toilets, bollards, or gates? Id like to see gates go down to z18. |
@Adamant36 Toilets was done in #3055, I've added the rest to task list above. |
I would add |
Is it equivalent of
Many of them appear in rural areas, can you give example of a place where they cause problems? |
Are wayside shrines found in urban areas in Europe? If they are mainly
rural, it would be good to be able to see them at z17
…On Mon, Oct 22, 2018 at 8:18 PM Tomasz Wójcik ***@***.***> wrote:
I would add amenity=charging_station and historic=wayside_shrine to the
list as they are small and not-so-important objects currently rendered from
z17. @kocio-pl <https://github.com/kocio-pl> What do you think?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#1745 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AoxshOkzqQjwuev-jZoyZn7pbw2ATTjUks5unamigaJpZM4Frmet>
.
|
Am Mo., 22. Okt. 2018 um 19:05 Uhr schrieb jeisenbe <
[email protected]>:
Are wayside shrines found in urban areas in Europe? If they are mainly
rural, it would be good to be able to see them at z17
Italy is full of them, in villages, towns, cities, in the country side, at
least we map things like these as wayside shrines:
https://www.fisheaters.com/images/roadsideshrine-sicily.jpg
I estimate we have only mapped a tiny fraction of them.
Cheers,
Martin
|
We had a notable example of this in Cracow: https://www.openstreetmap.org/#map=18/50.05670/19.93780 While I'm not sure that they are really wayside shrines (I guess most of them are just shrines and should be tagged some other way), there are multiple others that were once near a rural road and now they are inside the urban area, like this one: |
Yes, due to stats (https://en.wikipedia.org/wiki/Electric_car_use_by_country) electric cars are less than 1% of motor vehicles worldwide, what makes Here are some exaples of wayside shrines looking much more important (on the same level as e.g. museums), than they actually are: I think z18 would be better zoom level for both of these features. |
I wanted them to make the balance between being visible in the outdoor and not cluttering the urban areas, but if we are more strict about the size, than z18+ sounds good to me. |
None of the charging stations where I live ever get used by anyone. Except the homeless people to charge their cell phones once in awhile. So I agree with @Tomasz-W that they should be knocked down a zoom level or two. |
@Tomasz-W, id like to revisit this with drinking water and picnic tables. They are causing issues getting in the way of other things where I like to map. Do you have any opinion on either one. I see @kocio-pl mentioned drinking water as a possible option, but I didn't notice anywhere if you are for or against rendering it later. |
@Adamant36 As picnic tables are just a simple public furniture elements, I think they should be moved, Drinking water case is harder because, well... in hardcore cases it could save live. |
Picnic tables might be just a part of picnic site, and now they are rendered one step later (z16+ and z17+), but z18+ also makes sense for me, because they are small. We're not able to render outdoor in a proper way until we solve the problem how to recognize them (see #1957), so I don't consider OSM Carto to be usable for such purposes - there are different styles using OSM data, much better suited for this. In the outdoor any object is more interesting, simply because there are much less of them, including drinking water. But in general they are very small and sometimes it's a small building with taps, so both z19+ and z18+ make sense for me. |
I think such small amenities as amenity=post_box and amenity=atm are rendered too early now (z17, like shops for example). They are more important than trash cans (z19), so z18 seems like a natural choice for me.
This issue is related to #847 (comment) - I have proposed rendering amenity=recycling+recycling_type=container and amenity=waste_disposal also from z18, as they are also only of local interest, but more important than trash cans.
The text was updated successfully, but these errors were encountered: