Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Push some small amenities to higher zoom level #1745

Open
kocio-pl opened this issue Aug 14, 2015 · 44 comments
Open

Push some small amenities to higher zoom level #1745

kocio-pl opened this issue Aug 14, 2015 · 44 comments

Comments

@kocio-pl
Copy link
Collaborator

I think such small amenities as amenity=post_box and amenity=atm are rendered too early now (z17, like shops for example). They are more important than trash cans (z19), so z18 seems like a natural choice for me.

This issue is related to #847 (comment) - I have proposed rendering amenity=recycling+recycling_type=container and amenity=waste_disposal also from z18, as they are also only of local interest, but more important than trash cans.

@matkoniecz matkoniecz added this to the Bugs and improvements milestone Aug 14, 2015
@HolgerJeromin
Copy link
Contributor

Is getting the money less important than spending it? I am not sure.

@kocio-pl
Copy link
Collaborator Author

I think about proportions: the counterpart for shops is rather bank or post office IMO. ATM or post box are less important than them.

Similar case: amenity=recycling+recycling_type=centre are bigger/more important > amenity=recycling+recycling_type=container and amenity=waste_disposal are in between > trash cans are the least important.

Another progression of scale: monument > memorial sculpture > memorial plaque. There can be also many other such things - for example we already show supermarkets/malls etc earlier than convenience shops.

@kocio-pl
Copy link
Collaborator Author

Mockup with atm, post_box, telephone pushed from z17 to z18 (and emergency_phone to z19, as this is highly specialized kind of amenity):

z17:
small-amenities-17
z18:
small-amenities-18

I also think about moving them to the low priority group.

Another amenities that could be probably moved further down the zoom level and/or prioritized as less important could be toilettes and drinking_water, but I am not sure about them yet.

@pnorman
Copy link
Collaborator

pnorman commented Aug 18, 2015

Given the density of post boxes, I don't think they should be moved from z17 to z18.

@kocio-pl
Copy link
Collaborator Author

It's not about density of post boxes alone - they just add up to the whole density, as you can see, like other small amenities. They are clearly less important than post offices, so in my opinion it's perfectly legit to push them +1 zoom level.

In many places they are of less interest for general public (it's not a map mainly for tourists anyway) and there is a special issue about objects in rural areas, where every POI is more important than in the city/town/village, so post boxes should be more visible there (maybe even more than now - we'll see).

@HolgerJeromin
Copy link
Contributor

I think pnorman meant there are only postboxes every 1000 meter (in Germany).

@kocio-pl
Copy link
Collaborator Author

Yes, I have understood it this way too - does it sound like I haven't? In other words: I realize that their density is low, but there are other POIs on the map and the sum of all the elements can be dense (as on the example picture) and it makes sense to clear the things (even a bit) if we can. Those small elements tend to be placed around some more important ones, so they don't just take unused space, they rather make busy places even more busy.

BTW: do we have levels of importance or just normal/low groups? I think it would be the best to have more layers - post box may be less important than post office or a shop, but is more important than trash can.

@matthijsmelissen
Copy link
Collaborator

I think such small amenities as amenity=post_box and amenity=atm are rendered too early now (z17, like shops for example). They are more important than trash cans (z19), so z18 seems like a natural choice for me.

+1

@kocio-pl
Copy link
Collaborator Author

Detailed technical question: how should I create amenity-medium-priority group? I see that in project.yaml group with id amenity-low-priority has something like:

ORDER BY prio
          ) AS amenity_low_priority

but I don't understand how it is used then to find the real priority level?

Maybe we don't need additional group, because this line:

CASE WHEN amenity='waste_basket' THEN 2 ELSE 1 END AS prio

is the core information (the more number, the lower priority) and I could give 3 to waste_basket, 2 for current low priority objects and 1 for those small amenities?

Of course I understand I need to also edit amenity-points.mss file.

@pnorman
Copy link
Collaborator

pnorman commented Aug 18, 2015

Detailed technical question: how should I create amenity-medium-priority group? I see that in project.yaml group with id amenity-low-priority has something like:

ORDER BY prio
          ) AS amenity_low_priority

The name of the table in the SQL (amenity_low_priority) exists purely for ease of debugging SQL statements. It could be changed to anything and all that would happen is identifying which layer a query is from when just looking at a SQL log would become very difficult.

The id amenity-low-priority is significant, but is just a string of text. You could change it to anything, but would need to change the cartocss the same way.

The "priority" is determined by rendering order, i.e. where the layer is relative to other layers. Within the layer, the order rows are returned in is what determines rendering order, as well as cartocss order.

@matkoniecz
Copy link
Contributor

is the core information (the more number, the lower priority) and I could give 3 to waste_basket, 2 for current low priority objects and 1 for those small amenities?

Yes.

@kocio-pl
Copy link
Collaborator Author

I'm waiting for #1825 to be applied (and maybe also for #1802 (comment)), but the code is more or less ready and it's working as expected: global density change is not visible, but in some places it's getting more clear and the overall view is more uniform (smaller amenities don't mix with standard ones on z17 and ATMs should not eclipse banks on any zoom level).

@kocio-pl
Copy link
Collaborator Author

Another candidate for moving deeper: barrier=bollard should be rendered on z>=19 in my opinion. It also means some other small amenities could be rendered there:

  • fire hydrants (simply as a red dot)
  • traffic sign poles (silver dot)
  • street lamps (probably some lamp shape in black)

They are also used to be a part of bollard line.

@maraf24
Copy link

maraf24 commented Sep 13, 2015

barrier=bollard is very important kind of barrier that makes road impassable for cars. It should be rendered earlier not later. However, there are some bollards which are not part of the road. These could be rendered at z19.

@kocio-pl
Copy link
Collaborator Author

Thanks for the comment, it makes a lot of sense! Is there a way to detect in this style if the bollard is part of the road?

@matkoniecz
Copy link
Contributor

@kocio-pl

It should be possible. See turning circles - I think that currently only ones on highway ways are displayed.

@kocio-pl
Copy link
Collaborator Author

It should be rendered earlier not later.

Currently it is visible from z16 I guess, which zoom level would you like to have as the starting one?

@BalooUriza
Copy link

http://www.openstreetmap.org/#map=19/33.05398/-96.69600 seems to show that
bollards are rendered, though rather oddly (see the gap between 75 HOV and
75 on the link there; context is the Central Expressway in metro Dallas,
Texas.

On Sun, Sep 13, 2015 at 1:19 PM, Mateusz Konieczny <[email protected]

wrote:

@kocio-pl https://github.com/kocio-pl

It should be possible. See turning circles - I think that currently only
ones on highway ways are displayed.


Reply to this email directly or view it on GitHub
#1745 (comment)
.

@kocio-pl
Copy link
Collaborator Author

I guess highway=traffic_signals are also smaller amenities, so they should be moved to z>=18 instead of z>=17 (which is better for standard amenities).

@kocio-pl
Copy link
Collaborator Author

Now I think traffic_signals should be moved to z>=19, since they are not the even the small amenities worth looking for, rather part of a road infrastructure.

@matkoniecz
Copy link
Contributor

Note that some ideas were declined in #1884.

@kdudzik
Copy link

kdudzik commented Dec 14, 2016

@kocio-pl would you consider returning to this issue? Maybe #1884 could be split in smaller tasks. I'd be very interested in moving bollards (the ones that don't belong to a highway) to z19 as they tend to mess up the map at z16-z17:
http://www.openstreetmap.org/#map=16/52.2239/20.9200
image

@kocio-pl
Copy link
Collaborator Author

would you consider returning to this issue? Maybe #1884 could be split in smaller tasks.

Feel free to do it yourself. I can join the party, but I won't do it alone.

@kocio-pl
Copy link
Collaborator Author

I would like to get back to this issue - the summary of a rejected PR was:

against moving toilets - 1
against moving drinking_water - 2
against moving emergency_phone - 1
against moving traffic_signals - 2

The rest (atm, post_box and telephone) was not mentioned directly, however @imagico propositions is completely different and is hard to count.

Would it make sense to create separate PRs for these 3 types to be rendered from z18?

I still don't know how to push bollards to z19+ only if they are not part of highway, but I think this should not create controversy. Can anybody help me with this?

@kocio-pl
Copy link
Collaborator Author

kocio-pl commented Sep 6, 2017

Just a reminder to myself: there's a separate issue for loose bollards and hint how to do it (#2756).

@Tomasz-W
Copy link

Just for sort things out - there are 4 tags left in this issue:

  • amenity=drinking_water
  • amenity=atm
  • amenity=post_box
  • amenity=telephone

@Tomasz-W
Copy link

Tomasz-W commented Oct 6, 2018

@kocio-pl @Adamant36
Current state:

@Adamant36
Copy link
Contributor

Adamant36 commented Oct 6, 2018

@Tomasz-W, thanks. Amenity=post_box is currently an issue though, not a PR. Although, I guess I could have done one for it.

@Tomasz-W
Copy link

Tomasz-W commented Oct 6, 2018

@Adamant36 Oh, I see now. I think that splitting PRs into smaller parts is OK, but I find splitting issues (at least this one) unnecessary for the reason given in #3298 (comment) .

@Adamant36
Copy link
Contributor

@Tomasz-W, Good call, even if I disagree. I took the original comment by @kocio-pl about it as a possible suggestion and not a part of the issue. Since he didn't include it in the ATM PR. I guess that's part of the problem with not having unified way of doing things. Issues, lists in issues (sometimes referencing other issues, with their own lists), PRs, lists of PRs, PRs with lists of issues, etc, etc. It can easily turn into inception sometimes ;)

@Tomasz-W
Copy link

Tomasz-W commented Oct 16, 2018

@Adamant36
Update:

@Adamant36
Copy link
Contributor

Adamant36 commented Oct 18, 2018

Tomasz-W, did you happen to see issue #2665 about trees? Maybe it can be added to the list. At higher zoo. levels they do kind of clutter the map up and effect rendering in some places. Especially where they are over mapped.

Oh yeah, do you have any good examples of places where amenity=drinking_water and amenity=telephone are an issue?

What about toilets, bollards, or gates? Id like to see gates go down to z18.

@Tomasz-W
Copy link

@Adamant36 Toilets was done in #3055, I've added the rest to task list above.

@Tomasz-W
Copy link

Tomasz-W commented Oct 22, 2018

I would add amenity=charging_station and historic=wayside_shrine to the list as they are small and not-so-important objects currently rendered from z17. @kocio-pl What do you think?

@matkoniecz
Copy link
Contributor

matkoniecz commented Oct 22, 2018

amenity=charging_station

Is it equivalent of amenity=fuel or is there some major differences in size/importance?

historic=wayside_shrine

Many of them appear in rural areas, can you give example of a place where they cause problems?

@jeisenbe
Copy link
Collaborator

jeisenbe commented Oct 22, 2018 via email

@dieterdreist
Copy link

dieterdreist commented Oct 22, 2018 via email

@kocio-pl
Copy link
Collaborator Author

We had a notable example of this in Cracow:

https://www.openstreetmap.org/#map=18/50.05670/19.93780

While I'm not sure that they are really wayside shrines (I guess most of them are just shrines and should be tagged some other way), there are multiple others that were once near a rural road and now they are inside the urban area, like this one:

https://www.openstreetmap.org/node/5072410155

@Tomasz-W
Copy link

Tomasz-W commented Oct 22, 2018

Is it equivalent of amenity=fuel or is there some major differences in size/importance?

Yes, due to stats (https://en.wikipedia.org/wiki/Electric_car_use_by_country) electric cars are less than 1% of motor vehicles worldwide, what makes amenity=charging_station more a 'fun fact' than a equivalent of amenity=fuel for 99% of people at the moment.

Here are some exaples of wayside shrines looking much more important (on the same level as e.g. museums), than they actually are:
https://www.openstreetmap.org/node/4281335169#map=17/52.17473/21.04473
https://www.openstreetmap.org/node/4383580219#map=17/52.40529/16.93988

I think z18 would be better zoom level for both of these features.

@kocio-pl
Copy link
Collaborator Author

I wanted them to make the balance between being visible in the outdoor and not cluttering the urban areas, but if we are more strict about the size, than z18+ sounds good to me.

@Adamant36
Copy link
Contributor

None of the charging stations where I live ever get used by anyone. Except the homeless people to charge their cell phones once in awhile. So I agree with @Tomasz-W that they should be knocked down a zoom level or two.

@Adamant36
Copy link
Contributor

@Tomasz-W, id like to revisit this with drinking water and picnic tables. They are causing issues getting in the way of other things where I like to map. Do you have any opinion on either one. I see @kocio-pl mentioned drinking water as a possible option, but I didn't notice anywhere if you are for or against rendering it later.

@Tomasz-W
Copy link

Tomasz-W commented Dec 8, 2018

@Adamant36 As picnic tables are just a simple public furniture elements, I think they should be moved, Drinking water case is harder because, well... in hardcore cases it could save live.
To be honest - proper zoom levels for certain features are one of the hardest things to think about in OSM-Carto for me.

@kocio-pl
Copy link
Collaborator Author

kocio-pl commented Dec 8, 2018

Picnic tables might be just a part of picnic site, and now they are rendered one step later (z16+ and z17+), but z18+ also makes sense for me, because they are small.

We're not able to render outdoor in a proper way until we solve the problem how to recognize them (see #1957), so I don't consider OSM Carto to be usable for such purposes - there are different styles using OSM data, much better suited for this. In the outdoor any object is more interesting, simply because there are much less of them, including drinking water. But in general they are very small and sometimes it's a small building with taps, so both z19+ and z18+ make sense for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests